Opened 2 years ago

Closed 2 years ago

#23378 closed defect (fixed)

GradedCommutativeAlgebra constructor passes names as NCPolynomial_plural

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: algebra Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e050f07 (Commits) Commit: e050f07491132fe7b953b615315dba9148d671b0
Dependencies: Stopgaps:

Description

Even when constructing a GradedCommutativeAlgebra using variable names specified as string, somewhere down the line variable names get passed as NCPolynomial_plural.

Change History (9)

comment:1 Changed 2 years ago by jdemeyer

  • Authors set to Jeroen Demeyer

comment:2 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/gradedcommutativealgebra_constructor_passes_names_as_ncpolynomial_plural

comment:3 Changed 2 years ago by jdemeyer

  • Commit set to 5fdd99d6ca346fcb0b7d6ac48940efb4685c10cd
  • Status changed from new to needs_review

New commits:

5fdd99dUse variable_names() instead of gens()

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 2 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:6 Changed 2 years ago by git

  • Commit changed from 5fdd99d6ca346fcb0b7d6ac48940efb4685c10cd to e448e98e2ad06f8e01778a482d884f4ac30d3375

Branch pushed to git repo; I updated commit sha1. New commits:

e448e98Merge tag '8.1.beta2' into t/23378/gradedcommutativealgebra_constructor_passes_names_as_ncpolynomial_plural

comment:7 Changed 2 years ago by git

  • Commit changed from e448e98e2ad06f8e01778a482d884f4ac30d3375 to e050f07491132fe7b953b615315dba9148d671b0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e050f07PEP 8

comment:8 Changed 2 years ago by jdemeyer

  • Status changed from needs_work to positive_review

It seems that this was actually fixed in #23337. Now only some PEP 8 formatting remains...


New commits:

e050f07PEP 8

comment:9 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/gradedcommutativealgebra_constructor_passes_names_as_ncpolynomial_plural to e050f07491132fe7b953b615315dba9148d671b0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.