Opened 2 years ago

Closed 19 months ago

#23362 closed defect (fixed)

Upgrade to pandocfilters 1.4.2

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.0
Component: misc Keywords:
Cc: nthiery, tmonteil Merged in:
Authors: Volker Braun, Nicolas M. Thiéry Reviewers: Thierry Monteil
Report Upstream: N/A Work issues:
Branch: 177ff6f (Commits) Commit: 177ff6f796f690b7387299c01a48e41837aec019
Dependencies: Stopgaps:

Attachments (1)

markov.rst (5.5 KB) - added by vdelecroix 2 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 2 years ago by nthiery

Salut Vincent,

Please provide markov.rst!

comment:2 Changed 2 years ago by vdelecroix

Nothing to do with markov.rst. I can reproduce with any rst file.

comment:3 Changed 2 years ago by vdelecroix

(and Thierry can compile markov.rst)

Changed 2 years ago by vdelecroix

comment:4 Changed 2 years ago by nthiery

Then please provide steps to reproduce. Version of rst2ipynb. Installed through pip or the Sage package, running within sage -sh or not, ...

comment:5 Changed 2 years ago by nthiery

And what could possibly be the difference betwen your setup and Thierry. Ah also: pandoc's version; how it's installed.

comment:6 Changed 2 years ago by vdelecroix

  • Description modified (diff)
$ sage --version
SageMath version 8.0.rc0, Release Date: 2017-06-29
$ sage -sh
(sage-sh) $ pandoc --version
pandoc 1.19.2.1
Compiled with pandoc-types 1.17.0.5, texmath 0.9.4, skylighting 0.1.1.5
Default user data directory: /home/vincent/.pandoc
Copyright (C) 2006-2016 John MacFarlane

and ticket description updated

comment:7 Changed 2 years ago by vdelecroix

  • Description modified (diff)

comment:8 Changed 2 years ago by tmonteil

Related : #23415

comment:9 Changed 19 months ago by nthiery

Good news (well, not for me), I am now getting the same error on my machine ...

comment:10 Changed 19 months ago by nthiery

Ah ah, sounds like upgraded pandocfilters from 1.3.0 to 1.4.2 fixes the issue.

I had a bunch of recent pandocfilters here and there (in conda envs or ~/.local); presumably one of them was overriding sage's one, which prevented me to reproduce the error.

I will now work on updating sage's pandocfilters spkg.

comment:11 Changed 19 months ago by nthiery

Vincent, in the mean time, could you upgrade by hand your pandocfilters with:

    sage -pip install --upgrade pandocfilters

and double check that this indeed fixes the problem for you?

Last edited 19 months ago by nthiery (previous) (diff)

comment:12 Changed 19 months ago by nthiery

  • Branch set to u/nthiery/error_message_of_rst2ipynb_meaningless

comment:13 Changed 19 months ago by nthiery

  • Commit set to cdea81bed4cdc96888ca4d2abc62d3c8a56b6f03
  • Status changed from new to needs_review

In fact Volker had already put work on upgrading pandocfilters to 1.4.2 in #24484, as a piece of a large still in progress work. So I just had to fetch the diffs from there. I had to fix the checksums though. It should be a trivial merge in #24484 and unlikely to be an additional burden there; nevertheless I asked confirmation to Volker and we should wait for his feedback before getting this merged.


New commits:

cdea81b23362: upgrade pandocfilters to 1.4.2

comment:14 Changed 19 months ago by nthiery

  • Summary changed from error message of rst2ipynb meaningless to Upgrade to pandoc 1.4.2 (was: meaningless error message of rst2ipynb)

comment:15 Changed 19 months ago by git

  • Commit changed from cdea81bed4cdc96888ca4d2abc62d3c8a56b6f03 to 177ff6f796f690b7387299c01a48e41837aec019

Branch pushed to git repo; I updated commit sha1. New commits:

177ff6f23362: use pypi rather than github to fetch the tarball from

comment:16 Changed 19 months ago by nthiery

We have a green light from Volker and the checksum disprecancy is now understood and resolved.

Needs review!

comment:17 Changed 19 months ago by nthiery

  • Authors set to Voker Braun, Nicolas M. Thiéry

comment:18 Changed 19 months ago by nthiery

  • Authors changed from Voker Braun, Nicolas M. Thiéry to Volker Braun, Nicolas M. Thiéry

comment:19 Changed 19 months ago by tmonteil

  • Description modified (diff)
  • Reviewers set to Thierry Monteil
  • Status changed from needs_review to positive_review
  • Summary changed from Upgrade to pandoc 1.4.2 (was: meaningless error message of rst2ipynb) to Upgrade to pandocfilters 1.4.2

Successfully tested on some worksheets.

comment:20 Changed 19 months ago by nthiery

Thank you Thierry!

comment:21 Changed 19 months ago by vbraun

  • Branch changed from u/nthiery/error_message_of_rst2ipynb_meaningless to 177ff6f796f690b7387299c01a48e41837aec019
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.