Opened 5 years ago

Closed 5 years ago

#23360 closed enhancement (fixed)

Upgrade to Cython 0.26

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: packages: standard Keywords:
Cc: embray Merged in:
Authors: Jeroen Demeyer Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 44030be (Commits, GitHub, GitLab) Commit: 44030be5598fe725d747dd4abe3a664da37e37f2
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This allows us to use an unpatched version of Cython again.

Tarball: ​https://pypi.python.org/packages/10/d5/753d2cb5073a9f4329d1ffed1de30b0458821780af8fdd8ba1ad5adb6f62/Cython-0.26.tar.gz

Change History (26)

comment:1 Changed 5 years ago by jdemeyer

  • Cc embray added
  • Description modified (diff)

comment:2 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/upgrade_to_cython_0_26

comment:4 follow-up: Changed 5 years ago by embray

  • Commit set to 325763f79d5894b6cea92bbb599461cb053f9fab

Needs review?

New commits:

​325763fUpgrade to Cython 0.26

comment:5 Changed 5 years ago by git

  • Commit changed from 325763f79d5894b6cea92bbb599461cb053f9fab to b263b70bde2eae0554f13a47c0378b5e0486911d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​b263b70Upgrade to Cython 0.26

comment:6 in reply to: ↑ 4 Changed 5 years ago by jdemeyer

Replying to embray:

Needs review?

No, Cython 0.26 is not released yet. This is just for testing the beta version now.

comment:7 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:8 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:9 Changed 5 years ago by git

  • Commit changed from b263b70bde2eae0554f13a47c0378b5e0486911d to 68b11ba83397383ec3153729cbbbe11d39fcc35b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​68b11baUpgrade to Cython 0.26

comment:10 Changed 5 years ago by git

  • Commit changed from 68b11ba83397383ec3153729cbbbe11d39fcc35b to 552878474e1d6f03031d27f24d81963aa73ff972

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​5528784Upgrade to Cython 0.26

comment:11 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:12 Changed 5 years ago by git

  • Commit changed from 552878474e1d6f03031d27f24d81963aa73ff972 to c6126ff59b694e775307a057077c33a2aeca7976

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​c6126ffUpgrade to Cython 0.26

comment:13 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:14 Changed 5 years ago by git

  • Commit changed from c6126ff59b694e775307a057077c33a2aeca7976 to ce5a03fd6241cccf2516888ef4285099d0dbb353

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ce5a03fUpgrade to Cython 0.26

comment:15 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:16 Changed 5 years ago by git

  • Commit changed from ce5a03fd6241cccf2516888ef4285099d0dbb353 to 44030be5598fe725d747dd4abe3a664da37e37f2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​44030beUpgrade to Cython 0.26

comment:17 Changed 5 years ago by jdemeyer

  • Status changed from new to needs_review

comment:18 follow-up: Changed 5 years ago by vdelecroix

I launched the test suite on quasar (Ubuntu x86_64). Build was successfull.

comment:19 in reply to: ↑ 18 Changed 5 years ago by vdelecroix

Replying to vdelecroix:

I launched the test suite on quasar (Ubuntu x86_64). Build was successfull.

And all tests pass.

comment:20 Changed 5 years ago by embray

Windows patchbot just got to it.

comment:21 Changed 5 years ago by chapoton

Patchbots will do nothing for this kind of spkg ticket.

comment:22 Changed 5 years ago by embray

Ah, I keep forgetting that. Why is that? You'd think one would want them to test new packages?

comment:23 Changed 5 years ago by chapoton

For safety reason, and because not so many people care about enhancing the patchbots. I have done my share.

comment:24 Changed 5 years ago by embray

If there were safety issues with an upstream package wouldn't we want to know that in the patchbots first, before just declaring them "fine" and then pushing them on all users?

comment:25 Changed 5 years ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

Compiles fine on Cygwin.

comment:26 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_to_cython_0_26 to 44030be5598fe725d747dd4abe3a664da37e37f2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.