Opened 4 years ago

Closed 4 years ago

#23314 closed defect (fixed)

Ignored exceptions in glpk_backend.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 2345e61 (Commits, GitHub, GitLab) Commit: 2345e6173811579c49ea7aec0884af4b0aeb7ddf
Dependencies: Stopgaps:

Status badges

Description

In the file src/sage/numerical/backends/glpk_backend.pyx, there are two ignored exceptions doctested(!), in get_row_stat and get_col_stat.

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ignored_exceptions_in_glpk_backend_pyx

comment:2 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 2345e6173811579c49ea7aec0884af4b0aeb7ddf
  • Status changed from new to needs_review

New commits:

​2345e61Fix ignored exceptions in glpk_backend.pyx

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ignored_exceptions_in_glpk_backend_pyx to 2345e6173811579c49ea7aec0884af4b0aeb7ddf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.