Opened 2 years ago

Closed 3 months ago

#23313 closed enhancement (fixed)

Add more conversions from giac II

Reported by: mforets Owned by:
Priority: major Milestone: sage-8.7
Component: interfaces Keywords: giac, special functions
Cc: frederichan, slelievre, tscrim Merged in:
Authors: Marcelo Forets Reviewers: Frédéric Chapoton, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 415a5ed (Commits) Commit: 415a5ed5c33183303ff67e2874e50b02f2a658cb
Dependencies: Stopgaps:

Description (last modified by slelievre)

Ticket #22706 was about adding special function conversions for the Giac interface.

In this ticket we add two more conversions: ln and euler_gamma.

Change History (16)

comment:1 Changed 2 years ago by mforets

  • Branch set to u/mforets/23313
  • Commit set to 3b770da74edc1e73bcb9c1f47abd4685ee408289

New commits:

3b770daadd two giac conversions

comment:2 Changed 8 months ago by slelievre

  • Cc frederichan slelievre added
  • Description modified (diff)
  • Milestone changed from sage-8.0 to sage-8.4

mforets, is this ready for review? Don't forget to set to needs_review.

comment:3 Changed 8 months ago by mforets

  • Status changed from new to needs_review

comment:4 Changed 8 months ago by mforets

Hi slelievre, thanks for the reminder. Yes I think it is ready, I just set it for review.

I have not been updating my tickets from sagetrac for a while now; i don't have much extra time this year.

Best, Marcelo.-

comment:5 Changed 8 months ago by mforets

  • Authors set to Marcelo Forets

comment:6 Changed 8 months ago by chapoton

  • Status changed from needs_review to needs_work

some failing doctests, see patchbot report

comment:7 Changed 3 months ago by chapoton

  • Branch changed from u/mforets/23313 to public/ticket/23313
  • Commit changed from 3b770da74edc1e73bcb9c1f47abd4685ee408289 to 7237fec64e12a65cd512e8e414ba64f8a78a8d40
  • Milestone changed from sage-8.4 to sage-8.7

New commits:

acc0930add two giac conversions
7237fectrac 23313 more giac conversions

comment:8 Changed 3 months ago by git

  • Commit changed from 7237fec64e12a65cd512e8e414ba64f8a78a8d40 to e83de5b29bb7673f6cd9864fcf9fabf5513b066b

Branch pushed to git repo; I updated commit sha1. New commits:

e83de5btrac 23313 fix doctest

comment:9 Changed 3 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:10 Changed 3 months ago by chapoton

green bot, so this should be good to go. Please review

comment:11 Changed 3 months ago by slelievre

Note that #27296 changes one of the same lines in src/sage/interfaces/giac.py, fixing the spelling of "independent" (currently in its French spelling "independant") so maybe coordinate that ticket and the present ticket.

comment:12 Changed 3 months ago by git

  • Commit changed from e83de5b29bb7673f6cd9864fcf9fabf5513b066b to 415a5ed5c33183303ff67e2874e50b02f2a658cb

Branch pushed to git repo; I updated commit sha1. New commits:

415a5edtrac 23313 more details in giac interface

comment:13 Changed 3 months ago by chapoton

I have made so that #27296 no longer touches the giac interface file

comment:14 Changed 3 months ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:15 Changed 3 months ago by tscrim

  • Reviewers set to Frédéric Chapoton, Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:16 Changed 3 months ago by vbraun

  • Branch changed from public/ticket/23313 to 415a5ed5c33183303ff67e2874e50b02f2a658cb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.