Opened 5 years ago
Closed 4 years ago
#23313 closed enhancement (fixed)
Add more conversions from giac II
Reported by:  Marcelo Forets  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  interfaces  Keywords:  giac, special functions 
Cc:  Han Frederic, Samuel Lelièvre, Travis Scrimshaw  Merged in:  
Authors:  Marcelo Forets  Reviewers:  Frédéric Chapoton, Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  415a5ed (Commits, GitHub, GitLab)  Commit:  415a5ed5c33183303ff67e2874e50b02f2a658cb 
Dependencies:  Stopgaps: 
Description (last modified by )
Ticket #22706 was about adding special function conversions
for the Giac interface.
In this ticket we add two more conversions: ln
and euler_gamma
.
Change History (16)
comment:1 Changed 5 years ago by
Branch:  → u/mforets/23313 

Commit:  → 3b770da74edc1e73bcb9c1f47abd4685ee408289 
comment:2 Changed 4 years ago by
Cc:  Han Frederic Samuel Lelièvre added 

Description:  modified (diff) 
Milestone:  sage8.0 → sage8.4 
mforets, is this ready for review? Don't forget to set to needs_review
.
comment:3 Changed 4 years ago by
Status:  new → needs_review 

comment:4 Changed 4 years ago by
Hi slelievre, thanks for the reminder. Yes I think it is ready, I just set it for review.
I have not been updating my tickets from sagetrac for a while now; i don't have much extra time this year.
Best, Marcelo.
comment:5 Changed 4 years ago by
Authors:  → Marcelo Forets 

comment:6 Changed 4 years ago by
Status:  needs_review → needs_work 

some failing doctests, see patchbot report
comment:7 Changed 4 years ago by
Branch:  u/mforets/23313 → public/ticket/23313 

Commit:  3b770da74edc1e73bcb9c1f47abd4685ee408289 → 7237fec64e12a65cd512e8e414ba64f8a78a8d40 
Milestone:  sage8.4 → sage8.7 
comment:8 Changed 4 years ago by
Commit:  7237fec64e12a65cd512e8e414ba64f8a78a8d40 → e83de5b29bb7673f6cd9864fcf9fabf5513b066b 

Branch pushed to git repo; I updated commit sha1. New commits:
e83de5b  trac 23313 fix doctest

comment:9 Changed 4 years ago by
Status:  needs_work → needs_review 

comment:11 Changed 4 years ago by
Note that #27296 changes one of the same lines in src/sage/interfaces/giac.py
,
fixing the spelling of "independent" (currently in its French spelling "independant")
so maybe coordinate that ticket and the present ticket.
comment:12 Changed 4 years ago by
Commit:  e83de5b29bb7673f6cd9864fcf9fabf5513b066b → 415a5ed5c33183303ff67e2874e50b02f2a658cb 

Branch pushed to git repo; I updated commit sha1. New commits:
415a5ed  trac 23313 more details in giac interface

comment:13 Changed 4 years ago by
I have made so that #27296 no longer touches the giac interface file
comment:15 Changed 4 years ago by
Reviewers:  → Frédéric Chapoton, Travis Scrimshaw 

Status:  needs_review → positive_review 
LGTM.
comment:16 Changed 4 years ago by
Branch:  public/ticket/23313 → 415a5ed5c33183303ff67e2874e50b02f2a658cb 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
add two giac conversions