Opened 4 years ago

Closed 4 years ago

#23301 closed enhancement (fixed)

py3: some care for cmp in some modular files

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: tscrim, jdemeyer, jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 76b8ae5 (Commits) Commit: 76b8ae5858cecba5e35912776f5956171235f16c
Dependencies: Stopgaps:

Description (last modified by chapoton)

namely lseries, congroup (very partial cure) and smoothchar

Change History (7)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/23301
  • Commit set to d0bdb05ca416e50288c4552a137cc0643e155a7b

New commits:

​d0bdb05py3: some care for cmp in modular (lseries, congroup, smoothchar)

comment:2 Changed 4 years ago by git

  • Commit changed from d0bdb05ca416e50288c4552a137cc0643e155a7b to 76b8ae5858cecba5e35912776f5956171235f16c

Branch pushed to git repo; I updated commit sha1. New commits:

​76b8ae5trac 23310 better eq

comment:3 Changed 4 years ago by chapoton

  • Description modified (diff)
  • Summary changed from py3: some care fore cmp in some modular files to py3: some care for cmp in some modular files

comment:4 Changed 4 years ago by chapoton

  • Status changed from new to needs_review

let us wait for a patchbot report

comment:5 Changed 4 years ago by chapoton

  • Cc tscrim jdemeyer jhpalmieri added

bot is morally green

comment:6 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23301 to 76b8ae5858cecba5e35912776f5956171235f16c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.