Opened 15 years ago

Closed 5 years ago

#2330 closed enhancement (fixed)

modforms -- implement computation of weight 1 forms in Sage

Reported by: was Owned by: craigcitro
Priority: major Milestone: sage-8.2
Component: modular forms Keywords:
Cc: Merged in:
Authors: David Loeffler Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 4229170 (Commits, GitHub, GitLab) Commit: 42291700f1c422209abf7862e87f0c65466ab9ec
Dependencies: Stopgaps:

Status badges

Description

Kevin Buzzard and I intend to do this ASAP based on algorithms he designed in 2002.

If you see this and are interested in helping, send me an email (wstein@…).

Change History (16)

comment:1 Changed 15 years ago by was

Type: defectenhancement

comment:2 Changed 15 years ago by AlexGhitza

Component: number theorymodular forms
Owner: changed from was to craigcitro

comment:3 Changed 9 years ago by jdemeyer

Milestone: sage-5.11sage-5.12

comment:4 Changed 9 years ago by vbraun_spam

Milestone: sage-6.1sage-6.2

comment:5 Changed 9 years ago by vbraun_spam

Milestone: sage-6.2sage-6.3

comment:6 Changed 8 years ago by vbraun_spam

Milestone: sage-6.3sage-6.4

comment:7 Changed 6 years ago by roed

Report Upstream: N/A

comment:8 Changed 5 years ago by davidloeffler

Branch: public/2330-weight1

comment:9 Changed 5 years ago by davidloeffler

Authors: David Loeffler
Commit: 84310cd1580d3d7b4b59ba916da4c71868ffd221
Status: newneeds_review

New commits:

84310cdImplementation of Schaeffer's algorithm for weight 1 forms

comment:10 Changed 5 years ago by roed

Reviewers: David Roe
Status: needs_reviewneeds_work

It's awesome to have weight 1 forms!

Overall, the code looks good. A few issues to be addressed:

  • There's a plugin failure complaining about two lines with non-ASCII characters
  • The definition of R in the docstring of modular_ratio_space is off by one compared to the usage of R in the code.

comment:11 Changed 5 years ago by git

Commit: 84310cd1580d3d7b4b59ba916da4c71868ffd22142291700f1c422209abf7862e87f0c65466ab9ec

Branch pushed to git repo; I updated commit sha1. New commits:

4229170Trac 2330: fixes requested by reviewer

comment:12 Changed 5 years ago by davidloeffler

Status: needs_workneeds_review

This should address those two issues.


New commits:

4229170Trac 2330: fixes requested by reviewer

comment:13 Changed 5 years ago by davidloeffler

I'm a bit puzzled that four out of the five patchbot reports for the first version of the code are reporting test failures, all of which are nothing to do with the ticket as far as I can see -- is there something wrong with the patchbot? Most of them seem to be timeout errors.

comment:14 Changed 5 years ago by roed

Status: needs_reviewpositive_review

I'm not sure what's wrong with the other patchbots, but I've seen some of these errors in other places. It's certainly not a problem with your code.

Looks good!

comment:15 Changed 5 years ago by chapoton

Milestone: sage-6.4sage-8.2

comment:16 Changed 5 years ago by vbraun

Branch: public/2330-weight142291700f1c422209abf7862e87f0c65466ab9ec
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.