Opened 3 years ago

Closed 3 years ago

#23289 closed defect (fixed)

polymake does not build with gcc.7.1

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.0
Component: packages: experimental Keywords:
Cc: mkoeppe Merged in:
Authors: Vincent Delecroix Reviewers: Volker Braun
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: 25e2301 (Commits) Commit: 25e230195c295302b5d01710d7ad3fe4981f66e4
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

The polymake experimental package does not compile with gcc (GCC) 7.1.1 (see polymake-3.1.log​). In this ​thread on polymake forum upstream reports the same issue. We adapt a very simple patch proposed in the thread.

Attachments (1)

polymake-3.1.log​ (42.1 KB) - added by vdelecroix 3 years ago.

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by vdelecroix

comment:1 Changed 3 years ago by vdelecroix

  • Description modified (diff)

comment:2 Changed 3 years ago by vdelecroix

  • Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.

comment:3 Changed 3 years ago by vdelecroix

  • Description modified (diff)
  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. Developers acknowledge bug.
  • Summary changed from polymake package does not (always) build to polymake does not build with gcc >= 7.0

comment:4 Changed 3 years ago by vdelecroix

  • Description modified (diff)
  • Summary changed from polymake does not build with gcc >= 7.0 to polymake does not build with gcc.7.1

comment:5 Changed 3 years ago by vdelecroix

  • Branch set to u/vdelecroix/23289
  • Commit set to 25e230195c295302b5d01710d7ad3fe4981f66e4
  • Description modified (diff)

New commits:

​25e230123289: patch for polymake compilation

comment:6 Changed 3 years ago by vdelecroix

  • Description modified (diff)
  • Status changed from new to needs_review

comment:7 Changed 3 years ago by vdelecroix

Not sure it is due to the patch but 

$ sage -t polymake.py --optional=sage,polymake
**********************************************************************
File "polymake.py", line 814, in sage.interfaces.polymake.Polymake._eval_line
Failed example:
    p.N_LATTICE_POINTS                # optional - polymake
Expected:
    used package latte
      LattE (Lattice point Enumeration) is a computer software dedicated to the
      problems of counting lattice points and integration inside convex polytopes.
      Copyright by Matthias Koeppe, Jesus A. De Loera and others.
      http://www.math.ucdavis.edu/~latte/
    27
Got:
    27
**********************************************************************
1 item had failures:
   1 of  13 in sage.interfaces.polymake.Polymake._eval_line
    [245 tests, 1 failure, 22.05 s]
----------------------------------------------------------------------
sage -t --warn-long 75.7 polymake.py  # 1 doctest failed
----------------------------------------------------------------------
Last edited 3 years ago by vdelecroix (previous) (diff)

comment:8 Changed 3 years ago by vbraun

  • Reviewers set to Volker Braun

Positive review after you put in the author name...

comment:9 Changed 3 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Status changed from needs_review to positive_review

oups

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/vdelecroix/23289 to 25e230195c295302b5d01710d7ad3fe4981f66e4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.