Opened 5 years ago

Closed 5 years ago

#23285 closed enhancement (fixed)

py3: get rid of cmp for formal groups of elliptic curves

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: John Cremona, Jeroen Demeyer, Travis Scrimshaw, wuthrich, David Roe Merged in:
Authors: Frédéric Chapoton Reviewers: Chris Wuthrich
Report Upstream: N/A Work issues:
Branch: b9fafe9 (Commits, GitHub, GitLab) Commit: b9fafe9bfc991010f6071b8fa5ddb03af6089ff7
Dependencies: Stopgaps:

Status badges

Description

as another micro-step to py3

also cleans the doc a little bit in the changed file

Change History (7)

comment:1 Changed 5 years ago by Frédéric Chapoton

Branch: u/chapoton/23285
Commit: 06699759fba9c30b470e778d76b512f23ff0d8fe
Status: newneeds_review

New commits:

0669975py3: get rid of cmp for formal groups of elliptic curves

comment:2 Changed 5 years ago by git

Commit: 06699759fba9c30b470e778d76b512f23ff0d8feb9fafe9bfc991010f6071b8fa5ddb03af6089ff7

Branch pushed to git repo; I updated commit sha1. New commits:

b9fafe9trac 23285 typo

comment:3 Changed 5 years ago by Frédéric Chapoton

Cc: wuthrich David Roe added

comment:4 Changed 5 years ago by wuthrich

All changes very good, but I have not tested.

comment:5 Changed 5 years ago by Frédéric Chapoton

green bot. Ready for a positive review ?

comment:6 Changed 5 years ago by wuthrich

Reviewers: Chris Wuthrich
Status: needs_reviewpositive_review

yop. doc also looks better.

comment:7 Changed 5 years ago by Volker Braun

Branch: u/chapoton/23285b9fafe9bfc991010f6071b8fa5ddb03af6089ff7
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.