Opened 3 years ago
Closed 3 years ago
#23246 closed enhancement (fixed)
Rational : Set a unique implementation for denom, denominator and numer, numerator
| Reported by: | vklein | Owned by: | vklein |
|---|---|---|---|
| Priority: | trivial | Milestone: | sage-8.0 |
| Component: | basic arithmetic | Keywords: | thursdaysbdx |
| Cc: | vdelecroix | Merged in: | |
| Authors: | Vincent Klein | Reviewers: | Vincent Delecroix |
| Report Upstream: | N/A | Work issues: | |
| Branch: | f8dfd2f (Commits) | Commit: | f8dfd2f277df4817b5cf9524e799bdc35128e1a9 |
| Dependencies: | Stopgaps: |
Description (last modified by )
In class Rational instance method denom and denominator have the same implementation (code duplication). The same goes for methods numer and numerator. This ticket
- Sets numer as an alias for numerator.
- Sets denom as an alias for denominator.
Change History (5)
comment:1 Changed 3 years ago by
- Owner changed from (none) to vklein
comment:2 Changed 3 years ago by
- Branch set to u/vklein/rational___set_a_unique_implementation_for_denom__denominator_and_numer__numerator
comment:3 Changed 3 years ago by
- Commit set to f8dfd2f277df4817b5cf9524e799bdc35128e1a9
- Status changed from new to needs_review
comment:4 Changed 3 years ago by
- Description modified (diff)
- Reviewers set to Vincent Delecroix
- Status changed from needs_review to positive_review
comment:5 Changed 3 years ago by
- Branch changed from u/vklein/rational___set_a_unique_implementation_for_denom__denominator_and_numer__numerator to f8dfd2f277df4817b5cf9524e799bdc35128e1a9
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
trac 23246 set numer and denom as alias of numerator and