Opened 5 years ago
Closed 5 years ago
#23239 closed enhancement (fixed)
py3: change in cmp for homset and ring morphisms
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.0 |
Component: | python3 | Keywords: | |
Cc: | tscrim, jdemeyer, jhpalmieri | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 1d19536 (Commits, GitHub, GitLab) | Commit: | 1d195361bf5b9da41a651df83aa1b21437343ed2 |
Dependencies: | Stopgaps: |
Description (last modified by )
as another step to py3
- transform
__cmp__
in homset to just__eq__
and__ne__
- change comparison of ring morphisms not to do <, >, <=, >= anymore
Change History (6)
comment:1 Changed 5 years ago by
- Branch set to u/chapoton/23239
- Commit set to 3ed480d3c520f995b5aeba46e2784a567f93f281
comment:2 Changed 5 years ago by
- Commit changed from 3ed480d3c520f995b5aeba46e2784a567f93f281 to 1d195361bf5b9da41a651df83aa1b21437343ed2
Branch pushed to git repo; I updated commit sha1. New commits:
1d19536 | trac 23239 simplify comparison of ring morphisms
|
comment:3 Changed 5 years ago by
- Cc tscrim jdemeyer jhpalmieri added
- Description modified (diff)
- Status changed from new to needs_review
- Summary changed from py3: get rid of __cmp__ and cmp in homset.py to py3: change in cmp for homset and ring morphisms
green bot, please review
comment:4 Changed 5 years ago by
- Description modified (diff)
comment:5 Changed 5 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:6 Changed 5 years ago by
- Branch changed from u/chapoton/23239 to 1d195361bf5b9da41a651df83aa1b21437343ed2
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3: no cmp in homset.py