Opened 2 years ago
Closed 2 years ago
#23228 closed defect (fixed)
Fix modulo operator for unramified floating point elements
Reported by:  saraedum  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  padics  Keywords:  
Cc:  vbraun  Merged in:  
Authors:  Julian Rüth  Reviewers:  David Roe, Xavier Caruso 
Report Upstream:  N/A  Work issues:  
Branch:  c0df0d2 (Commits)  Commit:  c0df0d2ca44883472d9b2c7ac080691047d0208d 
Dependencies:  Stopgaps: 
Description
Currently, the following produces the wrong result
sage: R.<a> = ZqFP(27,10000) sage: a%3 0
Change History (11)
comment:1 Changed 2 years ago by
 Branch set to u/saraedum/fix_modulo_operator_for_unramified_floating_point_elements
comment:2 Changed 2 years ago by
 Commit set to 7f64bdf6f272f064c54795044e7ffd3c45da2db1
 Status changed from new to needs_review
comment:4 Changed 2 years ago by
 Reviewers changed from David Roe to David Roe, Xavier Caruso
comment:6 Changed 2 years ago by
 Branch changed from u/saraedum/fix_modulo_operator_for_unramified_floating_point_elements to u/caruso/fix_modulo_operator_for_unramified_floating_point_elements
comment:7 Changed 2 years ago by
 Commit changed from 7f64bdf6f272f064c54795044e7ffd3c45da2db1 to c0df0d2ca44883472d9b2c7ac080691047d0208d
Weird, almost all these doctest failures seem unrelated to that ticket. And they all pass on my computer. I fixed a small issue and tried to merge that ticket with the latest version of develop. Let's see what the patchbot says.
New commits:
db7e7db  Merge branch 'u/saraedum/fix_modulo_operator_for_unramified_floating_point_elements' of git://trac.sagemath.org/sage into padic_modulo

c0df0d2  Fixed a doctest

comment:8 Changed 2 years ago by
Tests are still failing.
I don't understand why. If you guys have any ideas...
comment:10 Changed 2 years ago by
 Status changed from needs_work to positive_review
I'm getting that all tests pass on my machine as well.
comment:11 Changed 2 years ago by
 Branch changed from u/caruso/fix_modulo_operator_for_unramified_floating_point_elements to c0df0d2ca44883472d9b2c7ac080691047d0208d
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Fix % operator for floating point rings