Opened 4 years ago

Closed 4 years ago

#23223 closed enhancement (fixed)

py3: some changes about cmp in groups and combinat

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: tscrim, jdemeyer, jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0c89807 (Commits) Commit: 0c898071f4a02a6e1e743260c857db8a1eafa402
Dependencies: Stopgaps:

Description

as another tiny step towards py3

Change History (6)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/23223
  • Commit set to e2e5dc4a3f691362b6c07c44c19810b987a93fbc
  • Status changed from new to needs_review

New commits:

​7a7afb8trying to remove __cmp__ from element.pyx
​b616111Merge branch 'public/22297' in 8.0.b10
​e2e5dc4some work on cmp in groups and combinat

comment:2 Changed 4 years ago by git

  • Commit changed from e2e5dc4a3f691362b6c07c44c19810b987a93fbc to 0c898071f4a02a6e1e743260c857db8a1eafa402

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​0c89807some work on cmp in groups and combinat

comment:3 Changed 4 years ago by chapoton

  • Status changed from needs_review to needs_work

hmm, maybe this is again a case of "unique representation" ?

comment:4 Changed 4 years ago by chapoton

  • Cc tscrim jdemeyer jhpalmieri added
  • Status changed from needs_work to needs_review

It does not seem so.

Bot is essentially green, please review.

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

No, it is not; it is essentially a UniqueFactory object and needs comparison methods.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23223 to 0c898071f4a02a6e1e743260c857db8a1eafa402
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.