Opened 2 years ago

Closed 2 years ago

#23221 closed defect (fixed)

Coercion from floating point unramified rings to their fraction fields

Reported by: roed Owned by:
Priority: major Milestone: sage-8.0
Component: padics Keywords: sd87
Cc: saraedum Merged in:
Authors: David Roe Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: 8bdcee0 (Commits) Commit: 8bdcee096604cca57472c535e6b283e033825fe4
Dependencies: Stopgaps:

Description

sage: R.<a> = ZqFP(25)
sage: K = R.fraction_field()
sage: K.has_coerce_map_from(R)
Traceback (most recent call last)
...
UnboundLocalError: local variable 'coerce_map' referenced before assignment

Change History (8)

comment:1 Changed 2 years ago by roed

  • Branch set to u/roed/coercion_from_floating_point_unramified_rings_to_their_fractionf_fields

comment:2 Changed 2 years ago by saraedum

  • Branch changed from u/roed/coercion_from_floating_point_unramified_rings_to_their_fractionf_fields to u/saraedum/coercion_from_floating_point_unramified_rings_to_their_fractionf_fields

comment:3 Changed 2 years ago by saraedum

  • Commit set to 8bdcee096604cca57472c535e6b283e033825fe4

Feel free to set this to positive review if the patchbot is happy (and if you like my changes.)


New commits:

4b56533Add coercion to fraction field for floating point rings
8bdcee0fix documentation issues

comment:4 Changed 2 years ago by saraedum

  • Reviewers set to Julian Rüth

comment:5 Changed 2 years ago by saraedum

  • Authors set to David Roe

comment:6 Changed 2 years ago by roed

  • Status changed from new to needs_review
  • Summary changed from Coercion from floating point unramified rings to their fractionf fields to Coercion from floating point unramified rings to their fraction fields

comment:7 Changed 2 years ago by roed

  • Status changed from needs_review to positive_review

All tests pass.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/saraedum/coercion_from_floating_point_unramified_rings_to_their_fractionf_fields to 8bdcee096604cca57472c535e6b283e033825fe4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.