Opened 2 years ago

Closed 2 years ago

Last modified 3 months ago

#23219 closed enhancement (fixed)

Make cryptominisat an optional package

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-8.0
Component: packages: optional Keywords: sdl
Cc: slabbe Merged in:
Authors: Thierry Monteil Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b223033 (Commits) Commit: b22303345160ce65f32fbbc81aaa297732693ef7
Dependencies: #22818 Stopgaps:

Description

Cryptominisat was experimental since it did break Sage on 32bit architecture (see #19781). This has been fixed by #22817 and #22818, so let us make it optional again.

Change History (6)

comment:1 Changed 2 years ago by tmonteil

  • Branch set to u/tmonteil/make_cryptominisat_an_optional_package

comment:2 Changed 2 years ago by tmonteil

  • Authors set to Thierry Monteil
  • Cc slabbe added
  • Commit set to b22303345160ce65f32fbbc81aaa297732693ef7

Last 10 new commits:

be9db62#22818 : move documentation of INPUT from __init__ to the class, as suggested in comment:34.
0566102#22818 : pass options from SAT to CruptoMiniSat.
e382251#22818 : remove useless import.
5236281#22818 : comment 40.
6ed1c73Merge branch 't/22818/interface_cryptominisat_5' into t/22817/package_cryptominisat_5
9593ce6Merge
c9dd355 #22818 : comment 55.
c22de1d#22818 : comment 59.
ce47403Merge branch 'u/tmonteil/interface_cryptominisat_5' of trac.sagemath.org:sage into HEAD
b223033#23219 : make cryptominisat an optional package.

comment:3 Changed 2 years ago by tmonteil

  • Status changed from new to needs_review

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Agreed.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/tmonteil/make_cryptominisat_an_optional_package to b22303345160ce65f32fbbc81aaa297732693ef7
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 3 months ago by tmonteil

  • Keywords sdl added
Note: See TracTickets for help on using tickets.