Opened 4 years ago
Closed 3 years ago
#23218 closed enhancement (fixed)
Ramified extensions of general padic rings and fields
Reported by:  roed  Owned by:  

Priority:  major  Milestone:  sage8.4 
Component:  padics  Keywords:  sd87, padicIMA 
Cc:  saraedum, swewers, caruso  Merged in:  
Authors:  David Roe, Julian Rüth, Xavier Caruso  Reviewers:  Julian Rüth, Xavier Caruso, David Roe 
Report Upstream:  N/A  Work issues:  
Branch:  319f6d4 (Commits, GitHub, GitLab)  Commit:  319f6d49427c7a138aaf2ef31628c5ccb571be19 
Dependencies:  #23221, #23228, #23471, #25908, #21994  Stopgaps: 
Description
We should have support for relative extensions of padic rings and fields. This is particularly useful for totally ramified extensions of unramified extensions of Qp, which will represent a general absolute extension of Qp.
Attachments (1)
Change History (108)
comment:1 Changed 4 years ago by
 Branch set to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:2 Changed 4 years ago by
 Cc swewers caruso added
 Commit set to bcdc0691e9371550f9c28512a59735e3e6714768
comment:3 Changed 4 years ago by
 Commit changed from bcdc0691e9371550f9c28512a59735e3e6714768 to 1e4b2b44f55aeaf9501cbd54bba73935e4c84b10
Branch pushed to git repo; I updated commit sha1. New commits:
1e4b2b4  Working on relative ramified extensions

comment:4 Changed 4 years ago by
 Commit changed from 1e4b2b44f55aeaf9501cbd54bba73935e4c84b10 to 17a2ae0b2a8159a4b47a69be1ba86fea751aa135
Branch pushed to git repo; I updated commit sha1. New commits:
17a2ae0  Changes to make things build

comment:5 Changed 4 years ago by
 Dependencies set to #23221
comment:6 Changed 4 years ago by
 Commit changed from 17a2ae0b2a8159a4b47a69be1ba86fea751aa135 to 77850fb29295bc6237f86f09b09f3dae78018a22
Branch pushed to git repo; I updated commit sha1. New commits:
6470a1a  __init__ method on relative ramified FM parents

4b56533  Add coercion to fraction field for floating point rings

18f9d37  Merge branch 't/23220/coercion_from_floating_point_unramified_rings_to_their_fractionf_fields' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

77850fb  Fixing some problems with floating point in pushouts, adding type casts for celements in libs/linkages/padics/Polynomial*.pxi to allow access to __coeffs

comment:7 Changed 4 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields
comment:8 Changed 4 years ago by
 Branch changed from u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:9 Changed 4 years ago by
 Commit changed from 77850fb29295bc6237f86f09b09f3dae78018a22 to eafeefef088aa4206164d0b8aae2e22298a865e5
comment:10 Changed 4 years ago by
 Dependencies changed from #23221 to #23221, #23228
comment:11 Changed 4 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields
comment:12 Changed 4 years ago by
 Commit changed from eafeefef088aa4206164d0b8aae2e22298a865e5 to fd3ee0f2d09453ee9aed578277b579e0a768cd34
Branch pushed to git repo; I updated commit sha1. New commits:
fd3ee0f  Clarify calls of __init__ in cconstruct

comment:13 Changed 4 years ago by
 Branch changed from u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:14 Changed 4 years ago by
 Commit changed from fd3ee0f2d09453ee9aed578277b579e0a768cd34 to 0204e7f6f38d172e6c010bf2cd4d1cc05903ec55
Branch pushed to git repo; I updated commit sha1. New commits:
0204e7f  Make series printing work for twostep padic extension elements

comment:15 Changed 4 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields
comment:16 Changed 4 years ago by
 Commit changed from 0204e7f6f38d172e6c010bf2cd4d1cc05903ec55 to b51ab48daa1a0471207fc256ad5b9c4b10d57f91
Branch pushed to git repo; I updated commit sha1. New commits:
b51ab48  Implemented missing padic conversions

comment:17 Changed 4 years ago by
 Commit changed from b51ab48daa1a0471207fc256ad5b9c4b10d57f91 to a4c3bf53ea1d2c75b4cb87c7711009196995066d
Branch pushed to git repo; I updated commit sha1. New commits:
a4c3bf5  Fix missing cases in conversion

comment:18 Changed 4 years ago by
 Commit changed from a4c3bf53ea1d2c75b4cb87c7711009196995066d to 651e31f2f42e8fb7648212d60c45aa3decd96fad
Branch pushed to git repo; I updated commit sha1. New commits:
42a65ab  Working on series printing for twostep padics

0204e7f  Make series printing work for twostep padic extension elements

c7f71c1  Fixing terse printing

0674979  Merge branch 'u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23217/ramified_extensions_of_general_p_adic_rings_and_fields

4d4c973  cleanup and implementations in ramified linkage

651e31f  Caching methods in pow computer

comment:19 Changed 4 years ago by
 Commit changed from 651e31f2f42e8fb7648212d60c45aa3decd96fad to 19115e64dcfde35a8b035210ee92d9d783dbfef7
Branch pushed to git repo; I updated commit sha1. New commits:
19115e6  fix shifting

comment:20 Changed 4 years ago by
 Commit changed from 19115e64dcfde35a8b035210ee92d9d783dbfef7 to 9a65ead34dc1367c01fb086b455d4d22f837052e
Branch pushed to git repo; I updated commit sha1. New commits:
1f89001  fix ccmp

39534c3  initialize temporary variables

b3e1001  explain why a conversion was not found

25888bc  fix typo

883b789  coercions and conversions from rationals into relative extensions

9a65ead  Move _coerce_map_from_ to the affected parents

comment:21 Changed 4 years ago by
 Dependencies changed from #23221, #23228 to #23221, #23228, #20310
comment:22 Changed 4 years ago by
 Dependencies changed from #23221, #23228, #20310 to #23221, #23228, #20310, #14825
comment:23 Changed 4 years ago by
 Branch changed from u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:24 Changed 4 years ago by
 Commit changed from 9a65ead34dc1367c01fb086b455d4d22f837052e to 497db77a4a6b2f3dbe01f67c0f511907861139c4
Branch pushed to git repo; I updated commit sha1. New commits:
497db77  Fixing pickling, adding relative extensions to factory, fixing bug in comparison

comment:25 Changed 4 years ago by
 Dependencies changed from #23221, #23228, #20310, #14825 to #23221, #23228, #20310, #14825, #23471
comment:26 Changed 4 years ago by
 Commit changed from 497db77a4a6b2f3dbe01f67c0f511907861139c4 to 2f3e44cfa74280cf1257ac2fb4f10e4d79ccb7f1
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
b7a0bff  Fix orders

77779ea  minor docstring changes

6e2495f  Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision

7428353  minor docstring fixes

bd15d71  add exact keyword

99dccf6  Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision

ef4ed33  Fix SEEALSO:

1754b44  Fix exact=True errors in the right branch

a29bf7a  Merge branch 't/20310/change_precision' into t/23471/padic_ext_conversion

2f3e44c  Merge branch 't/23471/padic_ext_conversion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:27 Changed 4 years ago by
 Commit changed from 2f3e44cfa74280cf1257ac2fb4f10e4d79ccb7f1 to e74a87fbb077bb206d4279a24093cb6eac5dced3
Branch pushed to git repo; I updated commit sha1. New commits:
f985aa0  Add ability to call with arguments

9763d7a  Fix implementation of _call_with_args

21a476e  Merge branch 't/23471/padic_ext_conversion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

e5d46b6  Move _shift_seed to PowComputer_relative_eis

3b52f2c  Fix bug from args being a tuple, not a list

e74a87f  Merge branch 't/23471/padic_ext_conversion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:28 Changed 4 years ago by
 Commit changed from e74a87fbb077bb206d4279a24093cb6eac5dced3 to 5c0aa4e6989abb97522e8abb5bd1beacb3eba24d
comment:29 Changed 4 years ago by
 Commit changed from 5c0aa4e6989abb97522e8abb5bd1beacb3eba24d to 1cb5597c0369540bf294b015a14993d2bb42d121
Branch pushed to git repo; I updated commit sha1. New commits:
1cb5597  Base change exact polynomial when creating PowComputer

comment:30 Changed 4 years ago by
 Commit changed from 1cb5597c0369540bf294b015a14993d2bb42d121 to 4eeb18b0220ad6434a092e436a14dacf9047e357
Branch pushed to git repo; I updated commit sha1. New commits:
4eeb18b  Injections from the base ring for relative padic extensions

comment:31 Changed 4 years ago by
 Commit changed from 4eeb18b0220ad6434a092e436a14dacf9047e357 to d037d153f7a20fb538ef669928b8009afd8458cd
comment:32 Changed 4 years ago by
 Commit changed from d037d153f7a20fb538ef669928b8009afd8458cd to a6b4361165f4856e59aa632a65d4acff8dc41b57
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
7f87069  Fix segfault

b9c2fe4  Fix pickling of sections for padic coercions

6ba62dd  Fix SEEALSO again

e9c4c39  Merge branch 'u/roed/allow_exact_defining_polynomials_for_p_adic_extensions' of git://trac.sagemath.org/sage into t/23331/allow_exact_defining_polynomials_for_p_adic_extensions

561f5ac  Fix doctest errors

3142701  Merge branch 'u/roed/change_precision' of git://trac.sagemath.org/sage into t/20310/change_precision

138d939  Fix string representation doctest from #22103

1eeb367  Merge branch 't/20310/change_precision' into t/14825/polynomial_representation_of_a_padic_number

1d1ad89  Merge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion

a6b4361  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:33 Changed 4 years ago by
 Commit changed from a6b4361165f4856e59aa632a65d4acff8dc41b57 to e20132124de474ef311a7eb12b6521ecd481d0c1
Branch pushed to git repo; I updated commit sha1. New commits:
e201321  Make conversion from residue field work for two step extensions

comment:34 Changed 4 years ago by
 Dependencies changed from #23221, #23228, #20310, #14825, #23471 to #23221, #23228, #23471
comment:35 Changed 4 years ago by
 Commit changed from e20132124de474ef311a7eb12b6521ecd481d0c1 to 392a5b654f7e352ab7997d0dc4001ea503970a11
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
0b7fd02  default docstring layout

def3897  replace p with pi and clarify meaning of expansion

99c40d6  add unit test for expansion

6732d38  coefficients might be lists in the maximal unramified subextension

acc606a  Merge branch 'u/saraedum/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number

40737f6  Fix some of the errors in _test_expansion

6efed0b  Merge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number

2b93c3c  Merge branch 'develop' into t/23471/padic_ext_conversion

3fc818a  Merge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion

392a5b6  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:36 Changed 4 years ago by
 Commit changed from 392a5b654f7e352ab7997d0dc4001ea503970a11 to 9633e88ef31981f60123a92f0b8ba22f786a87e3
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
d7d5fb6  Fixing documentation

8f34757  Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

46f9cae  Merge branch 'develop' into t/14825/polynomial_representation_of_a_padic_number

e51c0f5  Merge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number

b6457b1  Moving SEEALSO to the end of the docstring

b81b722  Remove use of depraceted list()

04a1579  Fix NOTES blocks

6764ea2  Merge branch 'develop' into t/14825/polynomial_representation_of_a_padic_number

0c58970  Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion

9633e88  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:37 Changed 4 years ago by
 Commit changed from 9633e88ef31981f60123a92f0b8ba22f786a87e3 to ef0f2d9f8bcb1c965be18bccd19ad62bd8eae9a8
comment:38 Changed 4 years ago by
 Commit changed from ef0f2d9f8bcb1c965be18bccd19ad62bd8eae9a8 to 493625a9491d289195c60cf4baae0a91644c6057
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
6311b85  cimport fraction field element types

16f53ec  Remove sig_on from around cshift, since this can call python code in two step extensions

10cdb0c  Fix sign errors in calling cshift

6b995a4  Switch from clist to cexpansion_next and cexpansion_getitem

a5f4606  Undo debugging change

617f85b  Use conditional compilation to simplify code for relative ramified extensions

7aecc2f  switch from % operator to add_bigoh in reduction

0303c7b  Use integral coefficients for the internal polynomials representing twostep extension elements

690ba7d  Compute inertia degee in whole tower when printing twostep padic extension elements

493625a  Add coercion maps to fraction field for twostep extensions

comment:39 Changed 4 years ago by
 Commit changed from 493625a9491d289195c60cf4baae0a91644c6057 to 8939981e4b02ac12b86f943d93a8baef25e9af51
Branch pushed to git repo; I updated commit sha1. New commits:
501577b  Add modulus and defining polynomials for Qp and Zp for consistency

ce61f64  Improve base ring injections for relative extensions of padic fields

16477d3  Make conversion from residue field work for twostep extensions of padics

1c7cc71  Fix typo in section method for base ring injection in padic twostep extensions

8be1504  Fix bugs in creduce and ccoefficients for twostep padic extensions

d53df12  Add coerce_list back in to the _populate_coercion_lists_ call in pAdicExtensionGeneric.__init__

e68beee  Fix some padic doctests

635021a  Change _poly_rep to always return the polynomial representing the element, not the unit

67c1f14  Change the internal base ring for twostep extensions to not show precision when printing, fix bug in base ring coercion

8939981  Fix problems in expansion code

comment:40 Changed 3 years ago by
It seems that I have found a problem with this ticket. Here is my example:
sage: R=Zq(2^10) sage: P.<alpha>=R[] sage: R1.<t>=R.ext(alpha^2+2*alpha+2) sage: M1=matrix(R1, 2, 2)  NotImplementedError Traceback (most recent call last)
comment:41 Changed 3 years ago by
 Commit changed from 8939981e4b02ac12b86f943d93a8baef25e9af51 to f4ce9aab0ee53b70a26c9d959c124948ace0cba6
comment:42 Changed 3 years ago by
 Commit changed from f4ce9aab0ee53b70a26c9d959c124948ace0cba6 to e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
ce61f64  Improve base ring injections for relative extensions of padic fields

16477d3  Make conversion from residue field work for twostep extensions of padics

1c7cc71  Fix typo in section method for base ring injection in padic twostep extensions

8be1504  Fix bugs in creduce and ccoefficients for twostep padic extensions

d53df12  Add coerce_list back in to the _populate_coercion_lists_ call in pAdicExtensionGeneric.__init__

e68beee  Fix some padic doctests

635021a  Change _poly_rep to always return the polynomial representing the element, not the unit

67c1f14  Change the internal base ring for twostep extensions to not show precision when printing, fix bug in base ring coercion

8939981  Fix problems in expansion code

e3a1c86  Merge commit '8939981e4b02ac12b86f943d93a8baef25e9af51' of git://trac.sagemath.org/sage into t/23218/general_extensions

comment:43 Changed 3 years ago by
 Commit changed from e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d to 65f28536ad731c289db6a150a200d179c4f80647
comment:44 Changed 3 years ago by
 Commit changed from 65f28536ad731c289db6a150a200d179c4f80647 to e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
ce61f64  Improve base ring injections for relative extensions of padic fields

16477d3  Make conversion from residue field work for twostep extensions of padics

1c7cc71  Fix typo in section method for base ring injection in padic twostep extensions

8be1504  Fix bugs in creduce and ccoefficients for twostep padic extensions

d53df12  Add coerce_list back in to the _populate_coercion_lists_ call in pAdicExtensionGeneric.__init__

e68beee  Fix some padic doctests

635021a  Change _poly_rep to always return the polynomial representing the element, not the unit

67c1f14  Change the internal base ring for twostep extensions to not show precision when printing, fix bug in base ring coercion

8939981  Fix problems in expansion code

e3a1c86  Merge commit '8939981e4b02ac12b86f943d93a8baef25e9af51' of git://trac.sagemath.org/sage into t/23218/general_extensions

comment:45 Changed 3 years ago by
Sorry for the weird force pushes. Things got confused with #23344. It should be okay now, and a fastforward of the branch from an hour ago.
comment:46 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:47 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:48 Changed 3 years ago by
 Commit changed from e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d to 340420840699b6d99963d8f74e8dd8e4f5e63832
Here are a series of bugs/remarks (see also discussion on Zulip):
 the printing of the parent is not optimal
 there is an issue with precision with the computation of
x^p
 the methods
zero
andone
(of the parent) are not implemented  the method
expansion
is broken  coercion from
QQ
to a padic field does not always work (might be related to the previous item)  the method
polynomial
is broken
New commits:
d77b226  Ensure that coefficient lists are copied in the padic Polynomial linkage files

aa1c48b  Fix error in category for _convert_map_for_ in padic extension rings

73040f3  Handle base ring correctly in __init__ method for padic template elements

96e977b  Fix a few bugs and add some tests

f686d75  Merge branch 'develop' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

3404208  Merge branch 'u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:49 Changed 3 years ago by
 Keywords padicIMA added
comment:50 Changed 3 years ago by
_test_add, _test_elements, _test_log, _test_sub failed when running TestSuite? on the following 5adic Eisenstein field.
sage: K.<a> = Qq(125) sage: R.<x> = K[] sage: W.<w> = K.extension(x^3 + 25*x^2  5*a*x + 5*(1+a^2)) sage: TestSuite(W).run()
For _test_add, the line
tester.assertTrue(y.is_equal_to(zx,zprec))
fails. Even though the expressions z(x+y) and x+yz were fine, the expression zxy is not. (In my particular failure, they all had relative precision 60, x and z had absolute precision 60, y had absolute precision 63.)
comment:51 Changed 3 years ago by
 Commit changed from 340420840699b6d99963d8f74e8dd8e4f5e63832 to 740ff4fdf25c00e8561bc5da9cba96b2f99076ae
comment:52 Changed 3 years ago by
random_element fails because multiplying by an element in the base field with negative valuation throws a "ValueError?: negative valuation"
sage: K.<a> = Qq(125) sage: R.<t> = K[] sage: W.<w> = K.extension(t^3 + 5*(5*t^2 + (13*aa^2)*t + a)) sage: K(1/5)*w ValueError: negative valuation
comment:53 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:54 Changed 3 years ago by
 Commit changed from 740ff4fdf25c00e8561bc5da9cba96b2f99076ae to 17322fab7176cff718e2cf7c67a0668a47016d97
Branch pushed to git repo; I updated commit sha1. New commits:
debf1fc  Commit to make different from develop

25c86a6  Change printing for padic extensions

e74fe63  Doctest for the helper method _extension_type

17322fa  Merge branch 't/25908/padic_printing' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:55 Changed 3 years ago by
 Dependencies changed from #23221, #23228, #23471 to #23221, #23228, #23471, #25908
comment:56 Changed 3 years ago by
 Commit changed from 17322fab7176cff718e2cf7c67a0668a47016d97 to 8882d0387de76a1b60114e3faf2c13bf5bc52bb3
Branch pushed to git repo; I updated commit sha1. New commits:
8882d03  Fix expansion

comment:57 Changed 3 years ago by
Here is another bug:
sage: K.<a> = Qq(2^10, 10) sage: S.<X> = K[] sage: L.<pi> = K.extension(X^2  16*X + 2) sage: L(2,absprec=3) <repr(<sage.rings.padics.relative_ramified_CR.RelativeRamifiedCappedRelativeElement at 0x7febfb11d4d0>) failed: RuntimeError: repr_spec called on zero>
New commits:
8882d03  Fix expansion

comment:58 Changed 3 years ago by
 Commit changed from 8882d0387de76a1b60114e3faf2c13bf5bc52bb3 to 3654af843fe064c31b1d74005735c9c2a8e17439
Branch pushed to git repo; I updated commit sha1. New commits:
3654af8  Some fixes in the sqrt function

comment:59 Changed 3 years ago by
 Commit changed from 3654af843fe064c31b1d74005735c9c2a8e17439 to 5553da87de2b665fe9c1e89899f207fc33730f39
Branch pushed to git repo; I updated commit sha1. New commits:
5553da8  Remove a unwanted print statement

comment:60 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:61 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:62 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:63 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:64 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:65 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:66 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:67 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:68 Changed 3 years ago by
 Commit changed from 5553da87de2b665fe9c1e89899f207fc33730f39 to 899d9f6d3fa9e374978837763d8383384a2ca897
Branch pushed to git repo; I updated commit sha1. New commits:
899d9f6  Extra doctests in morphism.pyx

comment:69 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:70 Changed 3 years ago by
 Commit changed from 899d9f6d3fa9e374978837763d8383384a2ca897 to 8d064401fcade533b075bb50c4b3f5183dba5280
Branch pushed to git repo; I updated commit sha1. New commits:
8d06440  Fix sphinx problem

comment:71 Changed 3 years ago by
 Reviewers set to Julian Rüth, Xavier Caruso, David Roe
 Status changed from new to needs_review
All tests pass on our machines. Sending it to the patchbots.
comment:72 Changed 3 years ago by
There's still a bug with shifting:
sage: W.<a> = Zq(2^10,3) sage: S.<x> = W[] sage: OL.<pi> = W.extension(x^2  2*a*x + 2) sage: OL(1) >> 1 a + pi + pi^3 + a*pi^4 + O(pi^5)
The last answer should be 0
, I guess.
In any case, results are not coherent:
sage: (OL(1) >> 1) >> 1 (a^2 + 1) + a*pi + pi^2 + O(pi^4) sage: OL(1) >> 2 O(pi^4)
comment:73 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:74 Changed 3 years ago by
 Commit changed from 8d064401fcade533b075bb50c4b3f5183dba5280 to 5ffb2633b6c5c4cd0dc286967c73a32150d668f5
Branch pushed to git repo; I updated commit sha1. New commits:
5ffb263  replace creduce by normalize

comment:75 Changed 3 years ago by
 Commit changed from 5ffb2633b6c5c4cd0dc286967c73a32150d668f5 to 7e842e3ef5c839eb20e77ea68200d1483ab0a31c
Branch pushed to git repo; I updated commit sha1. New commits:
7e842e3  Avoid to call two times cremove

comment:76 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:77 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:78 Changed 3 years ago by
 Commit changed from 7e842e3ef5c839eb20e77ea68200d1483ab0a31c to e156f7fd66867ae53ed8c5de5462a8b7a55edaee
comment:79 Changed 3 years ago by
 Dependencies changed from #23221, #23228, #23471, #25908 to #23221, #23228, #23471, #25908, #21994
comment:80 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:81 Changed 3 years ago by
 Commit changed from e156f7fd66867ae53ed8c5de5462a8b7a55edaee to b979df8231f039194fd54df9dc58eb18f733fd2e
Branch pushed to git repo; I updated commit sha1. New commits:
b979df8  Remove a sig_on/sig_off

comment:82 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:83 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:84 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:85 Changed 3 years ago by
 Commit changed from b979df8231f039194fd54df9dc58eb18f733fd2e to b1a32368f0fd66a2b06fc5ea0f05d36f1520690d
I've foundand fixedsome bugs.
I'm not satisfied with this ticket. Positive review for me when patchbot is happy.
Last 10 new commits:
9340a8a  Fix a corner case

4d6623d  Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

2975633  Add _quo_rem to lattice precision

cabb63e  Merge branch 'u/caruso/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision

4fed21f  Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

aacb4c2  Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

0ea13c0  Fix two bugs: one in expansion, one in cshift

22840e5  Prevent _test_log to compute log(0)

87f4c43  Always creduce after cremove

b1a3236  Remove unwanted print statements

comment:86 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:87 Changed 3 years ago by
 Commit changed from b1a32368f0fd66a2b06fc5ea0f05d36f1520690d to ecf1155e3eacec4d776fa2d9be59e821118b009f
Branch pushed to git repo; I updated commit sha1. New commits:
ecf1155  Fix _get_unit in CA_template.pxi

comment:88 Changed 3 years ago by
 Commit changed from ecf1155e3eacec4d776fa2d9be59e821118b009f to b2d0d73379f3868fa1748d0322224c8d6ad49c43
Branch pushed to git repo; I updated commit sha1. New commits:
b2d0d73  Fixing doctests

comment:89 Changed 3 years ago by
 Commit changed from b2d0d73379f3868fa1748d0322224c8d6ad49c43 to ab5aab47f0664938bba7398a4e49d7e58c01c2eb
Branch pushed to git repo; I updated commit sha1. New commits:
ab5aab4  Fixing doctests and typos

comment:90 Changed 3 years ago by
 Commit changed from ab5aab47f0664938bba7398a4e49d7e58c01c2eb to 8576c59d682a5984a8b878bd58f521e8a7324bf8
Branch pushed to git repo; I updated commit sha1. New commits:
8576c59  Change construction functors for padics, making pushouts work in towers

comment:91 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:92 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:93 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:94 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:95 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:96 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields
comment:97 Changed 3 years ago by
 Commit changed from 8576c59d682a5984a8b878bd58f521e8a7324bf8 to fda2c7d412df29ce8aa7a4e13c5a2e21db144762
Branch pushed to git repo; I updated commit sha1. New commits:
fda2c7d  Adding documentation and fixing minor issues

comment:98 Changed 3 years ago by
 Commit changed from fda2c7d412df29ce8aa7a4e13c5a2e21db144762 to dc2df561ca58b0f389617c5ec2f9c5c57cc06269
Branch pushed to git repo; I updated commit sha1. New commits:
46744d6  Make _quo_rem more easily accessible to the user

c0da7de  Update documentation

c8ae6a7  Move the generic implementation of _quo_rem back from 23218

9662550  Merge branch 'u/roed/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision

162b44d  Fixing doctests, bad argument in floordiv

dc2df56  Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:99 Changed 3 years ago by
 Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields
comment:100 Changed 3 years ago by
 Commit changed from dc2df561ca58b0f389617c5ec2f9c5c57cc06269 to e639faebca801514e900f5e913b79003c5b02124
comment:101 Changed 3 years ago by
I think we're planning on ignoring the pyflakes plugin; that's a task for another ticket.
We did leave in the _unit
debugging method for relative_ramified_FP.pyx
. That should either get removed or documented.
I can finish this off in the next few days if you don't get a chance before your flight.
comment:102 Changed 3 years ago by
 Commit changed from e639faebca801514e900f5e913b79003c5b02124 to 319f6d49427c7a138aaf2ef31628c5ccb571be19
Branch pushed to git repo; I updated commit sha1. New commits:
319f6d4  Remove the debugging method _unit

comment:103 Changed 3 years ago by
I removed the method _unit
.
The plugin startup_module
says:
startup_modules Failed startup_modules  3 seconds
but I don't understand what's the problem.
New commits:
319f6d4  Remove the debugging method _unit

comment:104 Changed 3 years ago by
The latest patchbot report reports failures, but I think that they are not related to this ticket. Do you agree?
comment:105 Changed 3 years ago by
 Status changed from needs_review to positive_review
I agree. And the startup_module is just checking that new modules aren't unintentionally added to Sage when they shouldn't be. Since we're intending to, it's no problem.
I think we're all set!
comment:106 Changed 3 years ago by
 Milestone changed from sage8.0 to sage8.4
comment:107 Changed 3 years ago by
 Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to 319f6d49427c7a138aaf2ef31628c5ccb571be19
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Initial files to work on for 23218