Opened 18 months ago

Closed 4 months ago

#23218 closed enhancement (fixed)

Ramified extensions of general p-adic rings and fields

Reported by: roed Owned by:
Priority: major Milestone: sage-8.4
Component: padics Keywords: sd87, padicIMA
Cc: saraedum, swewers, caruso Merged in:
Authors: David Roe, Julian Rüth, Xavier Caruso Reviewers: Julian Rüth, Xavier Caruso, David Roe
Report Upstream: N/A Work issues:
Branch: 319f6d4 (Commits) Commit: 319f6d49427c7a138aaf2ef31628c5ccb571be19
Dependencies: #23221, #23228, #23471, #25908, #21994 Stopgaps:

Description

We should have support for relative extensions of p-adic rings and fields. This is particularly useful for totally ramified extensions of unramified extensions of Qp, which will represent a general absolute extension of Qp.

Attachments (1)

23218_over_23471.diff (130.7 KB) - added by roed 17 months ago.
Diff against #23471

Download all attachments as: .zip

Change History (108)

comment:1 Changed 18 months ago by roed

  • Branch set to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:2 Changed 18 months ago by saraedum

  • Cc swewers caruso added
  • Commit set to bcdc0691e9371550f9c28512a59735e3e6714768

New commits:

bcdc069Initial files to work on for 23218

comment:3 Changed 18 months ago by git

  • Commit changed from bcdc0691e9371550f9c28512a59735e3e6714768 to 1e4b2b44f55aeaf9501cbd54bba73935e4c84b10

Branch pushed to git repo; I updated commit sha1. New commits:

1e4b2b4Working on relative ramified extensions

comment:4 Changed 18 months ago by git

  • Commit changed from 1e4b2b44f55aeaf9501cbd54bba73935e4c84b10 to 17a2ae0b2a8159a4b47a69be1ba86fea751aa135

Branch pushed to git repo; I updated commit sha1. New commits:

17a2ae0Changes to make things build

comment:5 Changed 18 months ago by roed

  • Dependencies set to #23221

comment:6 Changed 18 months ago by git

  • Commit changed from 17a2ae0b2a8159a4b47a69be1ba86fea751aa135 to 77850fb29295bc6237f86f09b09f3dae78018a22

Branch pushed to git repo; I updated commit sha1. New commits:

6470a1a__init__ method on relative ramified FM parents
4b56533Add coercion to fraction field for floating point rings
18f9d37Merge branch 't/23220/coercion_from_floating_point_unramified_rings_to_their_fractionf_fields' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
77850fbFixing some problems with floating point in pushouts, adding type casts for celements in libs/linkages/padics/Polynomial*.pxi to allow access to __coeffs

comment:7 Changed 18 months ago by saraedum

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields

comment:8 Changed 18 months ago by roed

  • Branch changed from u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:9 Changed 18 months ago by git

  • Commit changed from 77850fb29295bc6237f86f09b09f3dae78018a22 to eafeefef088aa4206164d0b8aae2e22298a865e5

Branch pushed to git repo; I updated commit sha1. New commits:

f815759replace prec_cap with ram_prec_cap in many template.pxi files
eafeefeUse Polynomial_generic_dense_inexact in relative_ramified_FM

comment:10 Changed 18 months ago by saraedum

  • Dependencies changed from #23221 to #23221, #23228

comment:11 Changed 18 months ago by saraedum

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields

comment:12 Changed 18 months ago by git

  • Commit changed from eafeefef088aa4206164d0b8aae2e22298a865e5 to fd3ee0f2d09453ee9aed578277b579e0a768cd34

Branch pushed to git repo; I updated commit sha1. New commits:

fd3ee0fClarify calls of __init__ in cconstruct

comment:13 Changed 18 months ago by roed

  • Branch changed from u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:14 Changed 18 months ago by git

  • Commit changed from fd3ee0f2d09453ee9aed578277b579e0a768cd34 to 0204e7f6f38d172e6c010bf2cd4d1cc05903ec55

Branch pushed to git repo; I updated commit sha1. New commits:

0204e7fMake series printing work for two-step p-adic extension elements

comment:15 Changed 18 months ago by saraedum

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields

comment:16 Changed 18 months ago by git

  • Commit changed from 0204e7f6f38d172e6c010bf2cd4d1cc05903ec55 to b51ab48daa1a0471207fc256ad5b9c4b10d57f91

Branch pushed to git repo; I updated commit sha1. New commits:

b51ab48Implemented missing p-adic conversions

comment:17 Changed 18 months ago by git

  • Commit changed from b51ab48daa1a0471207fc256ad5b9c4b10d57f91 to a4c3bf53ea1d2c75b4cb87c7711009196995066d

Branch pushed to git repo; I updated commit sha1. New commits:

a4c3bf5Fix missing cases in conversion

comment:18 Changed 18 months ago by git

  • Commit changed from a4c3bf53ea1d2c75b4cb87c7711009196995066d to 651e31f2f42e8fb7648212d60c45aa3decd96fad

Branch pushed to git repo; I updated commit sha1. New commits:

42a65abWorking on series printing for two-step p-adics
0204e7fMake series printing work for two-step p-adic extension elements
c7f71c1Fixing terse printing
0674979Merge branch 'u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23217/ramified_extensions_of_general_p_adic_rings_and_fields
4d4c973cleanup and implementations in ramified linkage
651e31fCaching methods in pow computer

comment:19 Changed 18 months ago by git

  • Commit changed from 651e31f2f42e8fb7648212d60c45aa3decd96fad to 19115e64dcfde35a8b035210ee92d9d783dbfef7

Branch pushed to git repo; I updated commit sha1. New commits:

19115e6fix shifting

comment:20 Changed 18 months ago by git

  • Commit changed from 19115e64dcfde35a8b035210ee92d9d783dbfef7 to 9a65ead34dc1367c01fb086b455d4d22f837052e

Branch pushed to git repo; I updated commit sha1. New commits:

1f89001fix ccmp
39534c3initialize temporary variables
b3e1001explain why a conversion was not found
25888bcfix typo
883b789coercions and conversions from rationals into relative extensions
9a65eadMove _coerce_map_from_ to the affected parents

comment:21 Changed 18 months ago by roed

  • Dependencies changed from #23221, #23228 to #23221, #23228, #20310

comment:22 Changed 18 months ago by roed

  • Dependencies changed from #23221, #23228, #20310 to #23221, #23228, #20310, #14825

comment:23 Changed 18 months ago by roed

  • Branch changed from u/saraedum/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:24 Changed 17 months ago by git

  • Commit changed from 9a65ead34dc1367c01fb086b455d4d22f837052e to 497db77a4a6b2f3dbe01f67c0f511907861139c4

Branch pushed to git repo; I updated commit sha1. New commits:

497db77Fixing pickling, adding relative extensions to factory, fixing bug in comparison

comment:25 Changed 17 months ago by roed

  • Dependencies changed from #23221, #23228, #20310, #14825 to #23221, #23228, #20310, #14825, #23471

comment:26 Changed 17 months ago by git

  • Commit changed from 497db77a4a6b2f3dbe01f67c0f511907861139c4 to 2f3e44cfa74280cf1257ac2fb4f10e4d79ccb7f1

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b7a0bffFix orders
77779eaminor docstring changes
6e2495fMerge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision
7428353minor docstring fixes
bd15d71add exact keyword
99dccf6Merge branch 't/23331/allow_exact_defining_polynomials_for_p_adic_extensions' into t/20310/change_precision
ef4ed33Fix SEEALSO:
1754b44Fix exact=True errors in the right branch
a29bf7aMerge branch 't/20310/change_precision' into t/23471/padic_ext_conversion
2f3e44cMerge branch 't/23471/padic_ext_conversion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:27 Changed 17 months ago by git

  • Commit changed from 2f3e44cfa74280cf1257ac2fb4f10e4d79ccb7f1 to e74a87fbb077bb206d4279a24093cb6eac5dced3

Branch pushed to git repo; I updated commit sha1. New commits:

f985aa0Add ability to call with arguments
9763d7aFix implementation of _call_with_args
21a476eMerge branch 't/23471/padic_ext_conversion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
e5d46b6Move _shift_seed to PowComputer_relative_eis
3b52f2cFix bug from args being a tuple, not a list
e74a87fMerge branch 't/23471/padic_ext_conversion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:28 Changed 17 months ago by git

  • Commit changed from e74a87fbb077bb206d4279a24093cb6eac5dced3 to 5c0aa4e6989abb97522e8abb5bd1beacb3eba24d

Branch pushed to git repo; I updated commit sha1. New commits:

3cddbddFix doctests
8586517Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
5c0aa4eFix sign error in PowComputer_relative

comment:29 Changed 17 months ago by git

  • Commit changed from 5c0aa4e6989abb97522e8abb5bd1beacb3eba24d to 1cb5597c0369540bf294b015a14993d2bb42d121

Branch pushed to git repo; I updated commit sha1. New commits:

1cb5597Base change exact polynomial when creating PowComputer

comment:30 Changed 17 months ago by git

  • Commit changed from 1cb5597c0369540bf294b015a14993d2bb42d121 to 4eeb18b0220ad6434a092e436a14dacf9047e357

Branch pushed to git repo; I updated commit sha1. New commits:

4eeb18bInjections from the base ring for relative p-adic extensions

comment:31 Changed 17 months ago by git

  • Commit changed from 4eeb18b0220ad6434a092e436a14dacf9047e357 to d037d153f7a20fb538ef669928b8009afd8458cd

Branch pushed to git repo; I updated commit sha1. New commits:

1944974Add morphisms to and from residue field (still need doctests)
d037d15Merge branch 't/8240/residue_coercion' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:32 Changed 17 months ago by git

  • Commit changed from d037d153f7a20fb538ef669928b8009afd8458cd to a6b4361165f4856e59aa632a65d4acff8dc41b57

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

7f87069Fix segfault
b9c2fe4Fix pickling of sections for p-adic coercions
6ba62ddFix SEEALSO again
e9c4c39Merge branch 'u/roed/allow_exact_defining_polynomials_for_p_adic_extensions' of git://trac.sagemath.org/sage into t/23331/allow_exact_defining_polynomials_for_p_adic_extensions
561f5acFix doctest errors
3142701Merge branch 'u/roed/change_precision' of git://trac.sagemath.org/sage into t/20310/change_precision
138d939Fix string representation doctest from #22103
1eeb367Merge branch 't/20310/change_precision' into t/14825/polynomial_representation_of_a_padic_number
1d1ad89Merge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion
a6b4361Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

Changed 17 months ago by roed

Diff against #23471

comment:33 Changed 17 months ago by git

  • Commit changed from a6b4361165f4856e59aa632a65d4acff8dc41b57 to e20132124de474ef311a7eb12b6521ecd481d0c1

Branch pushed to git repo; I updated commit sha1. New commits:

e201321Make conversion from residue field work for two step extensions

comment:34 Changed 17 months ago by roed

  • Dependencies changed from #23221, #23228, #20310, #14825, #23471 to #23221, #23228, #23471

Update dependency chain: #23471 depends on #14825, which depends on #20310.

comment:35 Changed 16 months ago by git

  • Commit changed from e20132124de474ef311a7eb12b6521ecd481d0c1 to 392a5b654f7e352ab7997d0dc4001ea503970a11

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

0b7fd02default docstring layout
def3897replace p with pi and clarify meaning of expansion
99c40d6add unit test for expansion
6732d38coefficients might be lists in the maximal unramified subextension
acc606aMerge branch 'u/saraedum/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number
40737f6Fix some of the errors in _test_expansion
6efed0bMerge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number
2b93c3cMerge branch 'develop' into t/23471/padic_ext_conversion
3fc818aMerge branch 'u/roed/padic_ext_conversion' of git://trac.sagemath.org/sage into t/23471/padic_ext_conversion
392a5b6Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:36 Changed 15 months ago by git

  • Commit changed from 392a5b654f7e352ab7997d0dc4001ea503970a11 to 9633e88ef31981f60123a92f0b8ba22f786a87e3

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d7d5fb6Fixing documentation
8f34757Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion
46f9caeMerge branch 'develop' into t/14825/polynomial_representation_of_a_padic_number
e51c0f5Merge branch 'u/roed/polynomial_representation_of_a_padic_number' of git://trac.sagemath.org/sage into t/14825/polynomial_representation_of_a_padic_number
b6457b1Moving SEEALSO to the end of the docstring
b81b722Remove use of depraceted list()
04a1579Fix NOTES blocks
6764ea2Merge branch 'develop' into t/14825/polynomial_representation_of_a_padic_number
0c58970Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23471/padic_ext_conversion
9633e88Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:37 Changed 13 months ago by git

  • Commit changed from 9633e88ef31981f60123a92f0b8ba22f786a87e3 to ef0f2d9f8bcb1c965be18bccd19ad62bd8eae9a8

Branch pushed to git repo; I updated commit sha1. New commits:

1ad1dbaRemoving commented code in relative_ramified_FM.pyx
ef0f2d9Merge commit '1ad1dba6a2' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:38 Changed 13 months ago by git

  • Commit changed from ef0f2d9f8bcb1c965be18bccd19ad62bd8eae9a8 to 493625a9491d289195c60cf4baae0a91644c6057

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

6311b85cimport fraction field element types
16f53ecRemove sig_on from around cshift, since this can call python code in two step extensions
10cdb0cFix sign errors in calling cshift
6b995a4Switch from clist to cexpansion_next and cexpansion_getitem
a5f4606Undo debugging change
617f85bUse conditional compilation to simplify code for relative ramified extensions
7aecc2fswitch from % operator to add_bigoh in reduction
0303c7bUse integral coefficients for the internal polynomials representing two-step extension elements
690ba7dCompute inertia degee in whole tower when printing two-step p-adic extension elements
493625aAdd coercion maps to fraction field for two-step extensions

comment:39 Changed 13 months ago by git

  • Commit changed from 493625a9491d289195c60cf4baae0a91644c6057 to 8939981e4b02ac12b86f943d93a8baef25e9af51

Branch pushed to git repo; I updated commit sha1. New commits:

501577bAdd modulus and defining polynomials for Qp and Zp for consistency
ce61f64Improve base ring injections for relative extensions of p-adic fields
16477d3Make conversion from residue field work for two-step extensions of p-adics
1c7cc71Fix typo in section method for base ring injection in p-adic two-step extensions
8be1504Fix bugs in creduce and ccoefficients for two-step p-adic extensions
d53df12Add coerce_list back in to the _populate_coercion_lists_ call in pAdicExtensionGeneric.__init__
e68beeeFix some p-adic doctests
635021aChange _poly_rep to always return the polynomial representing the element, not the unit
67c1f14Change the internal base ring for two-step extensions to not show precision when printing, fix bug in base ring coercion
8939981Fix problems in expansion code

comment:40 Changed 12 months ago by lubicz

It seems that I have found a problem with this ticket. Here is my example:

sage: R=Zq(2^10)
sage: P.<alpha>=R[]
sage: R1.<t>=R.ext(alpha^2+2*alpha+2)
sage: M1=matrix(R1, 2, 2)
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)

comment:41 Changed 10 months ago by git

  • Commit changed from 8939981e4b02ac12b86f943d93a8baef25e9af51 to f4ce9aab0ee53b70a26c9d959c124948ace0cba6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e64d891added square for unramified 2-adic fields
f4ce9aaMerge branch 'u/lubicz/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23344/sqrt_2

comment:42 Changed 10 months ago by git

  • Commit changed from f4ce9aab0ee53b70a26c9d959c124948ace0cba6 to e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ce61f64Improve base ring injections for relative extensions of p-adic fields
16477d3Make conversion from residue field work for two-step extensions of p-adics
1c7cc71Fix typo in section method for base ring injection in p-adic two-step extensions
8be1504Fix bugs in creduce and ccoefficients for two-step p-adic extensions
d53df12Add coerce_list back in to the _populate_coercion_lists_ call in pAdicExtensionGeneric.__init__
e68beeeFix some p-adic doctests
635021aChange _poly_rep to always return the polynomial representing the element, not the unit
67c1f14Change the internal base ring for two-step extensions to not show precision when printing, fix bug in base ring coercion
8939981Fix problems in expansion code
e3a1c86Merge commit '8939981e4b02ac12b86f943d93a8baef25e9af51' of git://trac.sagemath.org/sage into t/23218/general_extensions

comment:43 Changed 10 months ago by git

  • Commit changed from e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d to 65f28536ad731c289db6a150a200d179c4f80647

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e64d891added square for unramified 2-adic fields
65f2853Merge commit 'e64d891c19b4b5bb1b2b8d666f16f02ad405c67e' of git://trac.sagemath.org/sage into t/23344/sqrt_2

comment:44 Changed 10 months ago by git

  • Commit changed from 65f28536ad731c289db6a150a200d179c4f80647 to e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ce61f64Improve base ring injections for relative extensions of p-adic fields
16477d3Make conversion from residue field work for two-step extensions of p-adics
1c7cc71Fix typo in section method for base ring injection in p-adic two-step extensions
8be1504Fix bugs in creduce and ccoefficients for two-step p-adic extensions
d53df12Add coerce_list back in to the _populate_coercion_lists_ call in pAdicExtensionGeneric.__init__
e68beeeFix some p-adic doctests
635021aChange _poly_rep to always return the polynomial representing the element, not the unit
67c1f14Change the internal base ring for two-step extensions to not show precision when printing, fix bug in base ring coercion
8939981Fix problems in expansion code
e3a1c86Merge commit '8939981e4b02ac12b86f943d93a8baef25e9af51' of git://trac.sagemath.org/sage into t/23218/general_extensions

comment:45 Changed 10 months ago by roed

Sorry for the weird force pushes. Things got confused with #23344. It should be okay now, and a fast-forward of the branch from an hour ago.

comment:46 Changed 9 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:47 Changed 9 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:48 Changed 7 months ago by caruso

  • Commit changed from e3a1c866f8fa3bc534e3434ab2ca066d470b5d5d to 340420840699b6d99963d8f74e8dd8e4f5e63832

Here are a series of bugs/remarks (see also discussion on Zulip):

  • the printing of the parent is not optimal
  • there is an issue with precision with the computation of x^p
  • the methods zero and one (of the parent) are not implemented
  • the method expansion is broken
  • coercion from QQ to a p-adic field does not always work (might be related to the previous item)
  • the method polynomial is broken

New commits:

d77b226Ensure that coefficient lists are copied in the p-adic Polynomial linkage files
aa1c48bFix error in category for _convert_map_for_ in p-adic extension rings
73040f3Handle base ring correctly in __init__ method for p-adic template elements
96e977bFix a few bugs and add some tests
f686d75Merge branch 'develop' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
3404208Merge branch 'u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:49 Changed 5 months ago by roed

  • Keywords padicIMA added

comment:50 Changed 5 months ago by varul

_test_add, _test_elements, _test_log, _test_sub failed when running TestSuite? on the following 5-adic Eisenstein field.

sage: K.<a> = Qq(125)
sage: R.<x> = K[]
sage: W.<w> = K.extension(x^3 + 25*x^2 - 5*a*x + 5*(1+a^2))
sage: TestSuite(W).run()

For _test_add, the line

tester.assertTrue(y.is_equal_to(z-x,zprec))

fails. Even though the expressions z-(x+y) and x+y-z were fine, the expression z-x-y is not. (In my particular failure, they all had relative precision 60, x and z had absolute precision 60, y had absolute precision 63.)

comment:51 Changed 5 months ago by git

  • Commit changed from 340420840699b6d99963d8f74e8dd8e4f5e63832 to 740ff4fdf25c00e8561bc5da9cba96b2f99076ae

Branch pushed to git repo; I updated commit sha1. New commits:

82c4ca0Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/general_extensions
740ff4fFix in_field for pow_comptuers of relative p-adic extensions

comment:52 Changed 5 months ago by varul

random_element fails because multiplying by an element in the base field with negative valuation throws a "ValueError?: negative valuation"

sage: K.<a> = Qq(125)
sage: R.<t> = K[]
sage: W.<w> = K.extension(t^3 + 5*(5*t^2 + (13*a-a^2)*t + a))
sage: K(1/5)*w
ValueError: negative valuation

comment:53 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:54 Changed 5 months ago by git

  • Commit changed from 740ff4fdf25c00e8561bc5da9cba96b2f99076ae to 17322fab7176cff718e2cf7c67a0668a47016d97

Branch pushed to git repo; I updated commit sha1. New commits:

debf1fcCommit to make different from develop
25c86a6Change printing for p-adic extensions
e74fe63Doctest for the helper method _extension_type
17322faMerge branch 't/25908/padic_printing' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:55 Changed 5 months ago by caruso

  • Dependencies changed from #23221, #23228, #23471 to #23221, #23228, #23471, #25908

comment:56 Changed 5 months ago by git

  • Commit changed from 17322fab7176cff718e2cf7c67a0668a47016d97 to 8882d0387de76a1b60114e3faf2c13bf5bc52bb3

Branch pushed to git repo; I updated commit sha1. New commits:

8882d03Fix expansion

comment:57 Changed 5 months ago by caruso

Here is another bug:

sage: K.<a> = Qq(2^10, 10)
sage: S.<X> = K[]
sage: L.<pi> = K.extension(X^2 - 16*X + 2)
sage: L(2,absprec=3)
<repr(<sage.rings.padics.relative_ramified_CR.RelativeRamifiedCappedRelativeElement at 0x7febfb11d4d0>) failed: RuntimeError: repr_spec called on zero>

New commits:

8882d03Fix expansion

comment:58 Changed 5 months ago by git

  • Commit changed from 8882d0387de76a1b60114e3faf2c13bf5bc52bb3 to 3654af843fe064c31b1d74005735c9c2a8e17439

Branch pushed to git repo; I updated commit sha1. New commits:

3654af8Some fixes in the sqrt function

comment:59 Changed 5 months ago by git

  • Commit changed from 3654af843fe064c31b1d74005735c9c2a8e17439 to 5553da87de2b665fe9c1e89899f207fc33730f39

Branch pushed to git repo; I updated commit sha1. New commits:

5553da8Remove a unwanted print statement

comment:60 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:61 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:62 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:63 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:64 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:65 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:66 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:67 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:68 Changed 5 months ago by git

  • Commit changed from 5553da87de2b665fe9c1e89899f207fc33730f39 to 899d9f6d3fa9e374978837763d8383384a2ca897

Branch pushed to git repo; I updated commit sha1. New commits:

899d9f6Extra doctests in morphism.pyx

comment:69 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:70 Changed 5 months ago by git

  • Commit changed from 899d9f6d3fa9e374978837763d8383384a2ca897 to 8d064401fcade533b075bb50c4b3f5183dba5280

Branch pushed to git repo; I updated commit sha1. New commits:

8d06440Fix sphinx problem

comment:71 Changed 5 months ago by roed

  • Authors set to David Roe, Julian Rüth, Xavier Caruso
  • Reviewers set to Julian Rüth, Xavier Caruso, David Roe
  • Status changed from new to needs_review

All tests pass on our machines. Sending it to the patchbots.

comment:72 Changed 5 months ago by caruso

There's still a bug with shifting:

sage: W.<a> = Zq(2^10,3)
sage: S.<x> = W[]
sage: OL.<pi> = W.extension(x^2 - 2*a*x + 2)
sage: OL(1) >> 1
a + pi + pi^3 + a*pi^4 + O(pi^5)

The last answer should be 0, I guess.

In any case, results are not coherent:

sage: (OL(1) >> 1) >> 1
(a^2 + 1) + a*pi + pi^2 + O(pi^4)
sage: OL(1) >> 2
O(pi^4)
Last edited 5 months ago by caruso (previous) (diff)

comment:73 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:74 Changed 5 months ago by git

  • Commit changed from 8d064401fcade533b075bb50c4b3f5183dba5280 to 5ffb2633b6c5c4cd0dc286967c73a32150d668f5

Branch pushed to git repo; I updated commit sha1. New commits:

5ffb263replace creduce by normalize

comment:75 Changed 5 months ago by git

  • Commit changed from 5ffb2633b6c5c4cd0dc286967c73a32150d668f5 to 7e842e3ef5c839eb20e77ea68200d1483ab0a31c

Branch pushed to git repo; I updated commit sha1. New commits:

7e842e3Avoid to call two times cremove

comment:76 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:77 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:78 Changed 5 months ago by git

  • Commit changed from 7e842e3ef5c839eb20e77ea68200d1483ab0a31c to e156f7fd66867ae53ed8c5de5462a8b7a55edaee

Branch pushed to git repo; I updated commit sha1. New commits:

8654e79Make several methods work (or raise a NotImplementedError) for extensions
e156f7fWrite a test suite for the shifting operator

comment:79 Changed 5 months ago by roed

  • Dependencies changed from #23221, #23228, #23471, #25908 to #23221, #23228, #23471, #25908, #21994

comment:80 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:81 Changed 5 months ago by git

  • Commit changed from e156f7fd66867ae53ed8c5de5462a8b7a55edaee to b979df8231f039194fd54df9dc58eb18f733fd2e

Branch pushed to git repo; I updated commit sha1. New commits:

b979df8Remove a sig_on/sig_off

comment:82 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:83 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:84 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:85 Changed 5 months ago by caruso

  • Commit changed from b979df8231f039194fd54df9dc58eb18f733fd2e to b1a32368f0fd66a2b06fc5ea0f05d36f1520690d

I've found--and fixed--some bugs.

I'm not satisfied with this ticket. Positive review for me when patchbot is happy.


Last 10 new commits:

9340a8aFix a corner case
4d6623dMerge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
2975633Add _quo_rem to lattice precision
cabb63eMerge branch 'u/caruso/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision
4fed21fMerge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
aacb4c2Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields
0ea13c0Fix two bugs: one in expansion, one in cshift
22840e5Prevent _test_log to compute log(0)
87f4c43Always creduce after cremove
b1a3236Remove unwanted print statements

comment:86 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:87 Changed 5 months ago by git

  • Commit changed from b1a32368f0fd66a2b06fc5ea0f05d36f1520690d to ecf1155e3eacec4d776fa2d9be59e821118b009f

Branch pushed to git repo; I updated commit sha1. New commits:

ecf1155Fix _get_unit in CA_template.pxi

comment:88 Changed 5 months ago by git

  • Commit changed from ecf1155e3eacec4d776fa2d9be59e821118b009f to b2d0d73379f3868fa1748d0322224c8d6ad49c43

Branch pushed to git repo; I updated commit sha1. New commits:

b2d0d73Fixing doctests

comment:89 Changed 5 months ago by git

  • Commit changed from b2d0d73379f3868fa1748d0322224c8d6ad49c43 to ab5aab47f0664938bba7398a4e49d7e58c01c2eb

Branch pushed to git repo; I updated commit sha1. New commits:

ab5aab4Fixing doctests and typos

comment:90 Changed 5 months ago by git

  • Commit changed from ab5aab47f0664938bba7398a4e49d7e58c01c2eb to 8576c59d682a5984a8b878bd58f521e8a7324bf8

Branch pushed to git repo; I updated commit sha1. New commits:

8576c59Change construction functors for p-adics, making pushouts work in towers

comment:91 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:92 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:93 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:94 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:95 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:96 Changed 5 months ago by roed

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to u/roed/ramified_extensions_of_general_p_adic_rings_and_fields

comment:97 Changed 5 months ago by git

  • Commit changed from 8576c59d682a5984a8b878bd58f521e8a7324bf8 to fda2c7d412df29ce8aa7a4e13c5a2e21db144762

Branch pushed to git repo; I updated commit sha1. New commits:

fda2c7dAdding documentation and fixing minor issues

comment:98 Changed 5 months ago by git

  • Commit changed from fda2c7d412df29ce8aa7a4e13c5a2e21db144762 to dc2df561ca58b0f389617c5ec2f9c5c57cc06269

Branch pushed to git repo; I updated commit sha1. New commits:

46744d6Make _quo_rem more easily accessible to the user
c0da7deUpdate documentation
c8ae6a7Move the generic implementation of _quo_rem back from 23218
9662550Merge branch 'u/roed/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision
162b44dFixing doctests, bad argument in floordiv
dc2df56Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields

comment:99 Changed 5 months ago by caruso

  • Branch changed from u/roed/ramified_extensions_of_general_p_adic_rings_and_fields to u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields

comment:100 Changed 5 months ago by caruso

  • Commit changed from dc2df561ca58b0f389617c5ec2f9c5c57cc06269 to e639faebca801514e900f5e913b79003c5b02124

All tests pass! (But several plugins failed.)

We're almost done!


New commits:

e7a5b08Reduce further after remove
e639faeAdd keyword reduce_relative in cremove

comment:101 Changed 5 months ago by roed

I think we're planning on ignoring the pyflakes plugin; that's a task for another ticket.

We did leave in the _unit debugging method for relative_ramified_FP.pyx. That should either get removed or documented.

I can finish this off in the next few days if you don't get a chance before your flight.

comment:102 Changed 5 months ago by git

  • Commit changed from e639faebca801514e900f5e913b79003c5b02124 to 319f6d49427c7a138aaf2ef31628c5ccb571be19

Branch pushed to git repo; I updated commit sha1. New commits:

319f6d4Remove the debugging method _unit

comment:103 Changed 5 months ago by caruso

I removed the method _unit.

The plugin startup_module says:

startup_modules Failed
startup_modules -- 3 seconds

but I don't understand what's the problem.


New commits:

319f6d4Remove the debugging method _unit

comment:104 Changed 5 months ago by caruso

The latest patchbot report reports failures, but I think that they are not related to this ticket. Do you agree?

comment:105 Changed 5 months ago by roed

  • Status changed from needs_review to positive_review

I agree. And the startup_module is just checking that new modules aren't unintentionally added to Sage when they shouldn't be. Since we're intending to, it's no problem.

I think we're all set!

comment:106 Changed 4 months ago by chapoton

  • Milestone changed from sage-8.0 to sage-8.4

comment:107 Changed 4 months ago by vbraun

  • Branch changed from u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields to 319f6d49427c7a138aaf2ef31628c5ccb571be19
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.