Opened 5 years ago

Closed 5 years ago

#23209 closed defect (duplicate)

Large performance regression since MPIR upgrade

Reported by: mmezzarobba Owned by:
Priority: critical Milestone: sage-duplicate/invalid/wontfix
Component: performance Keywords:
Cc: vdelecroix, jpflori, jdemeyer, vbraun Merged in:
Authors: Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: u/mmezzarobba/mpir_gnu_as (Commits, GitHub, GitLab) Commit: 26420450be58a7a301e975d9671ff16017ebeff0
Dependencies: Stopgaps:

Status badges

Description

Due to a bug introduced in #22493, MPIR is built without assembly support on many systems, causing a significant performance regression for pretty much everything in sage.

Change History (10)

comment:1 Changed 5 years ago by mmezzarobba

  • Component changed from PLEASE CHANGE to performance
  • Status changed from new to needs_review

comment:2 follow-up: Changed 5 years ago by tscrim

You should also bump the version to make sure this gets recompiled (i.e., treat this like a changed patch).

comment:3 Changed 5 years ago by git

  • Commit changed from ee4536bb60f11b46aaa889995f0e2c271c032fe9 to 26420450be58a7a301e975d9671ff16017ebeff0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2642045Fix detection of GNU as version in mpir spkg-install

comment:4 in reply to: ↑ 2 Changed 5 years ago by mmezzarobba

Replying to tscrim:

You should also bump the version to make sure this gets recompiled (i.e., treat this like a changed patch).

Done, thanks. (I hate working with sage packages.)

comment:5 Changed 5 years ago by tscrim

  • Cc jdemeyer vbruan added

Unfortunately I don't have the technical expertise to comment on the change itself.

comment:6 Changed 5 years ago by dimpase

  • Cc vbraun added; vbruan removed

comment:7 Changed 5 years ago by tscrim

This conflicts with beta10.

comment:8 follow-up: Changed 5 years ago by tscrim

  • Milestone changed from sage-8.0 to sage-duplicate/invalid/wontfix

Actually, I think this was inadvertently fixed by #23146.

comment:9 in reply to: ↑ 8 Changed 5 years ago by mmezzarobba

  • Status changed from needs_review to positive_review

Replying to tscrim:

Actually, I think this was inadvertently fixed by #23146.

Indeed.

comment:10 Changed 5 years ago by jdemeyer

  • Authors Marc Mezzarobba deleted
  • Resolution set to duplicate
  • Reviewers set to Marc Mezzarobba
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.