Opened 3 years ago

Closed 3 years ago

#23208 closed enhancement (fixed)

Enhanced backtrace on test timeout

Reported by: vbraun Owned by:
Priority: major Milestone: sage-8.0
Component: doctest framework Keywords:
Cc: fbissey, roed, jdemeyer, jpflori Merged in:
Authors: Volker Braun Reviewers: Julian Rüth, François Bissey
Report Upstream: N/A Work issues:
Branch: 155137b (Commits) Commit: 155137b02d31fc419ed8ee0a2ea33f9d53c01a9b
Dependencies: Stopgaps:

Description

Test timeout frequently and not reproducably on the buildbot. It would be so much nicer if one would be able to see where the process was stuck...

Change History (13)

comment:1 Changed 3 years ago by vbraun

  • Branch set to u/vbraun/enhanced_backtrace_on_test_timeout

comment:2 Changed 3 years ago by git

  • Commit set to 43291991d3c0f03eff492897abed00ec9ebdfbaa

Branch pushed to git repo; I updated commit sha1. New commits:

4329199Fix doctest

comment:3 Changed 3 years ago by vbraun

  • Status changed from new to needs_review

comment:4 Changed 3 years ago by vbraun

  • Cc fbissey added

comment:5 Changed 3 years ago by vbraun

  • Cc roed jdemeyer added

comment:6 Changed 3 years ago by fbissey

+        This method is only called if there is something wrong with the
+        worker. Under normal circumstances, the worker is supported to
+        exit by himself after finishing.

"supported"? Do you mean "supposed"?

comment:7 Changed 3 years ago by saraedum

  • Branch changed from u/vbraun/enhanced_backtrace_on_test_timeout to u/saraedum/enhanced_backtrace_on_test_timeout

comment:8 Changed 3 years ago by saraedum

  • Commit changed from 43291991d3c0f03eff492897abed00ec9ebdfbaa to 15f70b90c5e87a6ca948af288d6560e360e78cdf
  • Reviewers set to Julian Rüth

Feel free to set this to positive review if the tests pass (and if you are happy with the fix proposed by fbissey.)


New commits:

15f70b9fix typo

comment:9 Changed 3 years ago by jpflori

  • Cc jpflori added

comment:10 Changed 3 years ago by fbissey

Speaking of typos:

+        worker. Under normal circumstances, the worker is supposed to
+        exit by himself after finishing.

Now, I am French, and I make this mistake often, to ascribe neutral gender to male gender. himself -> itself

Apart from that I don't really have any objection in principle to this ticket, I'd love to have backtrace on those hanging process. Whether it will be useful is another question that cannot be answered without trying.

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/saraedum/enhanced_backtrace_on_test_timeout to u/vbraun/enhanced_backtrace_on_test_timeout

comment:12 Changed 3 years ago by vbraun

  • Commit changed from 15f70b90c5e87a6ca948af288d6560e360e78cdf to 155137b02d31fc419ed8ee0a2ea33f9d53c01a9b
  • Reviewers changed from Julian Rüth to Julian Rüth, François Bissey
  • Status changed from needs_review to positive_review

New commits:

155137bFix another typo

comment:13 Changed 3 years ago by vbraun

  • Branch changed from u/vbraun/enhanced_backtrace_on_test_timeout to 155137b02d31fc419ed8ee0a2ea33f9d53c01a9b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.