Opened 4 years ago

Closed 4 years ago

#23205 closed defect (fixed)

Do not require surjectivity to be implemented for composite injectivity

Reported by: saraedum Owned by:
Priority: major Milestone: sage-8.0
Component: commutative algebra Keywords: sd86.5
Cc: Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: b21c370 (Commits, GitHub, GitLab) Commit: b21c370a4a3501d1ce35463e535fceaa258ccc83
Dependencies: Stopgaps:

Status badges

Description

Currently, this fails even though all morphisms are known to be injective.

sage: QQ.hom(QQbar)*ZZ.hom(QQ)

Composite map:
  From: Integer Ring
  To:   Algebraic Field
  Defn:   Ring Coercion morphism:
          From: Integer Ring
          To:   Rational Field
        then
          Ring Coercion morphism:
          From: Rational Field
          To:   Algebraic Field
sage: _.is_injective()

Change History (4)

comment:1 Changed 4 years ago by saraedum

  • Branch set to u/saraedum/do_not_require_surjectivity_to_be_implemented_for_composite_injectivity

comment:2 Changed 4 years ago by saraedum

  • Commit set to b21c370a4a3501d1ce35463e535fceaa258ccc83
  • Status changed from new to needs_review

New commits:

b21c370Do not require is_surjective/is_injective to be implemented on as many morphisms to decide injectivity/surjectivity of composite maps

comment:3 Changed 4 years ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

All tests pass; looks good.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/saraedum/do_not_require_surjectivity_to_be_implemented_for_composite_injectivity to b21c370a4a3501d1ce35463e535fceaa258ccc83
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.