Opened 4 years ago
Closed 4 years ago
#23191 closed enhancement (fixed)
default implementation of inverse_of_unit()
Reported by: | saraedum | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.0 |
Component: | commutative algebra | Keywords: | sd86.5 |
Cc: | Merged in: | ||
Authors: | Julian Rüth | Reviewers: | David Roe |
Report Upstream: | N/A | Work issues: | |
Branch: | baee716 (Commits, GitHub, GitLab) | Commit: | baee716de596637d075ae814ef45167b38ea95dd |
Dependencies: | Stopgaps: |
Description (last modified by )
Not all ring elements provide inverse_of_unit()
sage: R.<x> = ZZ[] sage: S = R.quo(x^2 + x + 1) sage: S(1).inverse_of_unit() NotImplementedError
But we could always try to invert and see if the result is in the same parent.
Change History (8)
comment:1 Changed 4 years ago by
- Branch set to u/saraedum/default_implementation_of_inverse_of_unit__
comment:2 Changed 4 years ago by
- Commit set to ac3c3f83077061875e2826e05e6789b8bdb8cdfc
- Status changed from new to needs_review
comment:3 Changed 4 years ago by
- Commit changed from ac3c3f83077061875e2826e05e6789b8bdb8cdfc to 4c1dee458a94835c20ee6cec260bec9dcb29311b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
4c1dee4 | Add a default implementation of inverse_of_unit() for rings
|
comment:4 Changed 4 years ago by
- Description modified (diff)
comment:5 Changed 4 years ago by
- Branch changed from u/saraedum/default_implementation_of_inverse_of_unit__ to u/roed/default_implementation_of_inverse_of_unit__
comment:6 Changed 4 years ago by
- Commit changed from 4c1dee458a94835c20ee6cec260bec9dcb29311b to baee716de596637d075ae814ef45167b38ea95dd
- Status changed from needs_review to positive_review
I fixed a couple doctests (and ran all tests). Looks good.
New commits:
baee716 | Add inverse_of_unit to list of methods in polynomial quotient ring
|
comment:7 Changed 4 years ago by
- Reviewers set to David Roe
comment:8 Changed 4 years ago by
- Branch changed from u/roed/default_implementation_of_inverse_of_unit__ to baee716de596637d075ae814ef45167b38ea95dd
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Add a default implementation of inverse_of_unit() for rings