Opened 6 years ago

Closed 5 years ago

#23191 closed enhancement (fixed)

default implementation of inverse_of_unit()

Reported by: Julian Rüth Owned by:
Priority: minor Milestone: sage-8.0
Component: commutative algebra Keywords: sd86.5
Cc: Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: baee716 (Commits, GitHub, GitLab) Commit: baee716de596637d075ae814ef45167b38ea95dd
Dependencies: Stopgaps:

Status badges

Description (last modified by Julian Rüth)

Not all ring elements provide inverse_of_unit()

sage: R.<x> = ZZ[]
sage: S = R.quo(x^2 + x + 1)
sage: S(1).inverse_of_unit()
NotImplementedError

But we could always try to invert and see if the result is in the same parent.

Change History (8)

comment:1 Changed 6 years ago by Julian Rüth

Branch: u/saraedum/default_implementation_of_inverse_of_unit__

comment:2 Changed 6 years ago by Julian Rüth

Authors: Julian Rüth
Commit: ac3c3f83077061875e2826e05e6789b8bdb8cdfc
Status: newneeds_review

New commits:

ac3c3f8Add a default implementation of inverse_of_unit() for rings

comment:3 Changed 6 years ago by git

Commit: ac3c3f83077061875e2826e05e6789b8bdb8cdfc4c1dee458a94835c20ee6cec260bec9dcb29311b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4c1dee4Add a default implementation of inverse_of_unit() for rings

comment:4 Changed 6 years ago by Julian Rüth

Description: modified (diff)

comment:5 Changed 6 years ago by David Roe

Branch: u/saraedum/default_implementation_of_inverse_of_unit__u/roed/default_implementation_of_inverse_of_unit__

comment:6 Changed 6 years ago by David Roe

Commit: 4c1dee458a94835c20ee6cec260bec9dcb29311bbaee716de596637d075ae814ef45167b38ea95dd
Status: needs_reviewpositive_review

I fixed a couple doctests (and ran all tests). Looks good.


New commits:

baee716Add inverse_of_unit to list of methods in polynomial quotient ring

comment:7 Changed 5 years ago by Jeroen Demeyer

Reviewers: David Roe

comment:8 Changed 5 years ago by Volker Braun

Branch: u/roed/default_implementation_of_inverse_of_unit__baee716de596637d075ae814ef45167b38ea95dd
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.