Opened 5 years ago

Closed 5 years ago

#23188 closed enhancement (fixed)

p-adic rings embed into their fraction fields

Reported by: saraedum Owned by:
Priority: minor Milestone: sage-8.0
Component: padics Keywords: sd86.5
Cc: roed Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 2deaa0f (Commits, GitHub, GitLab) Commit: 2deaa0fedc581c87b35f99b9362d4bfd831d4a26
Dependencies: Stopgaps:

Status badges

Description

Currently, this fails: 

sage: R.<a> = ZqCA(9)
sage: R.fraction_field().coerce_map_from(R).is_injective()
NotImplementedError

Change History (5)

comment:1 Changed 5 years ago by saraedum

  • Branch set to u/saraedum/p_adic_rings_embed_into_their_fraction_fields

comment:2 Changed 5 years ago by git

  • Commit set to 2deaa0fedc581c87b35f99b9362d4bfd831d4a26

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2deaa0fImplement is_injective/is_surjective for inclusions of p-adic rings into their fraction fields

comment:3 Changed 5 years ago by saraedum

  • Authors set to Julian Rüth
  • Cc roed added
  • Status changed from new to needs_review

comment:4 Changed 5 years ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Seems fine to me.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/saraedum/p_adic_rings_embed_into_their_fraction_fields to 2deaa0fedc581c87b35f99b9362d4bfd831d4a26
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.