Changes between Initial Version and Version 5 of Ticket #23186


Ignore:
Timestamp:
06/10/17 00:36:07 (2 years ago)
Author:
tscrim
Comment:

Because to do something at the category level, you should be doing something for all objects in that category, not for one specific object (in a specific implementation). Now, if you wanted to have something in Rings checking if a morphism to ZZ was surjective returning True, then that would be good because it is true for all rings (of characteristic 0). Although map has a concrete implementation of is_surjective, which is a technical detail that would need to be worked around (which that method probably should be lifted to the category of set morphisms).

The fix LGTM.


New commits:

79fd62aZZ is not onto QQ

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23186

    • Property Status changed from new to positive_review
    • Property Authors changed from to Julian Rüth
    • Property Branch changed from to u/saraedum/zz___qq_is_not_onto
    • Property Reviewers changed from to Travis Scrimshaw
    • Property Commit changed from to 79fd62a8c40632891cf32502a3d80709edc68cf8
  • Ticket #23186 – Description

    initial v5  
    55}}}
    66
    7 To fix this, we could change this on the category level by telling a morphism of rings whose domain is `ZZ` that it is surjective iff its codomain is `ZZ` or `Zmod`.
     7To fix this, we make the coercion morphism know it is not surjective.