Opened 2 years ago

Last modified 13 days ago

#23172 needs_work defect

Slowness with unramified extensions of Qp

Reported by: caruso Owned by:
Priority: major Milestone: sage-8.0
Component: padics Keywords: sd87, padicIMA, padicBordeaux
Cc: Merged in:
Authors: Vishal Arul Reviewers: Xavier Caruso
Report Upstream: N/A Work issues:
Branch: u/roed/residue_speed (Commits) Commit: f4cb4053c391f8f81a69b9050cc5cbf719e0dcc5
Dependencies: Stopgaps:

Description (last modified by varul)

I noticed that the methods residue and _div_ are ridiculously slow over Zq(p^n, prec) when prec is very large.

Note: the original purpose of the ticket seems to have been resolved due to improvements to expansion method.

Change History (13)

comment:1 Changed 2 years ago by roed

  • Keywords sd87 added

comment:2 Changed 14 months ago by roed

  • Keywords padicIMA added

comment:3 Changed 14 months ago by roed

  • Branch set to u/roed/residue_speed

comment:4 Changed 14 months ago by git

  • Commit set to 8ad3281d0345d1627b79c8b450b61ae8e487c948

Branch pushed to git repo; I updated commit sha1. New commits:

8ad3281Add test for residue

comment:5 Changed 14 months ago by varul

  • Branch changed from u/roed/residue_speed to u/varul/residue_speed

comment:6 Changed 14 months ago by varul

  • Commit changed from 8ad3281d0345d1627b79c8b450b61ae8e487c948 to 15c3eb07461debe7d8ccc882aad098bfb37f5f89
  • Description modified (diff)

New commits:

15c3eb0Made residue function faster

comment:7 Changed 14 months ago by varul

  • Authors set to varul
  • Status changed from new to needs_review

comment:8 Changed 14 months ago by caruso

  • Authors changed from varul to Vishal Arul
  • Reviewers set to Xavier Caruso

Looks good to me.

Positive review if the patchbot is happy.

comment:9 Changed 14 months ago by caruso

Patchbot says:

sage -t --long src/sage/rings/padics/padic_base_leaves.py  # 12 doctests failed
sage -t --long src/sage/schemes/hyperelliptic_curves/hyperelliptic_padic_field.py  # 37 doctests failed
sage -t --long src/sage/rings/padics/padic_extension_leaves.py  # 2 doctests failed
sage -t --long src/sage/rings/padics/padic_valuation.py  # 2 doctests failed
sage -t --long src/sage/rings/padics/local_generic.py  # 3 doctests failed
sage -t --long src/sage/rings/padics/padic_ZZ_pX_CR_element.pyx  # 5 doctests failed
sage -t --long src/sage/rings/valuation/gauss_valuation.py  # 1 doctest failed
sage -t --long src/sage/rings/padics/padic_generic.py  # 1 doctest failed

comment:10 Changed 14 months ago by caruso

  • Status changed from needs_review to needs_work

comment:11 Changed 2 weeks ago by roed

  • Keywords padicBordeaux added

comment:12 Changed 13 days ago by roed

  • Branch changed from u/varul/residue_speed to u/roed/residue_speed

comment:13 Changed 13 days ago by roed

  • Commit changed from 15c3eb07461debe7d8ccc882aad098bfb37f5f89 to f4cb4053c391f8f81a69b9050cc5cbf719e0dcc5

I just merged in 8.9.beta9


New commits:

f4cb405Merge branch 'u/varul/residue_speed' of git://trac.sagemath.org/sage into 23172_residue_speed
Note: See TracTickets for help on using tickets.