Opened 5 years ago
Closed 5 years ago
#23168 closed enhancement (fixed)
is_irreducible can be implemented on the parent as _is_irreducible_univariate_polynomial
Reported by: | saraedum | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.0 |
Component: | commutative algebra | Keywords: | sd86.5 |
Cc: | Merged in: | ||
Authors: | Julian Rüth | Reviewers: | David Roe |
Report Upstream: | N/A | Work issues: | |
Branch: | 99f2268 (Commits, GitHub, GitLab) | Commit: | 99f226891e7fca94a0ccdd4a47077012b8dfd2da |
Dependencies: | Stopgaps: |
Description (last modified by )
Just like .factor
can call ._factor_univariate_polynomial
, .is_irreducible
should be able to call ._is_irreducible_univariate_polynomial
.
Before:
sage: R.<x> = QQbar[] sage: f = R.random_element(degree=10) sage: %timeit f.is_irreducible() 10 loops, best of 3: 21.6 ms per loop
After:
sage: R.<x> = QQbar[] sage: f = R.random_element(degree=1000) sage: %timeit f.is_irreducible() The slowest run took 18.76 times longer than the fastest. This could mean that an intermediate result is being cached. 100000 loops, best of 3: 2.3 us per loop
Change History (12)
comment:1 Changed 5 years ago by
- Keywords sd86.5 added
comment:2 Changed 5 years ago by
- Branch set to u/saraedum/is_irreducible_can_be_implemented_on_the_parent_as__is_irreducible_univariate_polynomial
comment:3 Changed 5 years ago by
- Commit set to aa9d12a0d897038d8dee5fdef494ec6c7ed76950
- Description modified (diff)
- Status changed from new to needs_review
comment:4 Changed 5 years ago by
- Description modified (diff)
comment:5 Changed 5 years ago by
- Description modified (diff)
comment:6 Changed 5 years ago by
- Status changed from needs_review to positive_review
Looks good to me, and the patchbot checks out (both the coverage complaint and the doctests failures are phantoms). See #23202 as a followup.
comment:8 Changed 5 years ago by
- Reviewers set to David Roe
- Status changed from needs_work to positive_review
Reviewer name set
comment:10 Changed 5 years ago by
- Commit changed from aa9d12a0d897038d8dee5fdef494ec6c7ed76950 to 99f226891e7fca94a0ccdd4a47077012b8dfd2da
Branch pushed to git repo; I updated commit sha1. New commits:
99f2268 | Merge branch 'develop' into t/23168/is_irreducible_can_be_implemented_on_the_parent_as__is_irreducible_univariate_polynomial
|
comment:11 Changed 5 years ago by
- Status changed from needs_work to positive_review
Trivial doctest conflict. Setting it back to positive review.
New commits:
99f2268 | Merge branch 'develop' into t/23168/is_irreducible_can_be_implemented_on_the_parent_as__is_irreducible_univariate_polynomial
|
comment:12 Changed 5 years ago by
- Branch changed from u/saraedum/is_irreducible_can_be_implemented_on_the_parent_as__is_irreducible_univariate_polynomial to 99f226891e7fca94a0ccdd4a47077012b8dfd2da
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
is_irreducible() can be implemented on the base