Opened 4 years ago

Closed 4 years ago

#23165 closed enhancement (fixed)

valence polynomial for posets

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.0
Component: combinatorics Keywords:
Cc: jmantysalo, darij, boussica Merged in:
Authors: Frédéric Chapoton Reviewers: Darij Grinberg, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 5f45084 (Commits) Commit: 5f45084a37a8053627da60a147b46610c6f2b631
Dependencies: Stopgaps:

Description

as a simple useful invariant to have, much finer than cardinality, and still multiplicative for Cartesian product.

Change History (12)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/23165
  • Commit set to 88295c7ad7c2fde67034a418983a6743835e23a8
  • Status changed from new to needs_review

New commits:

88295c7implement valence polynomial for posets

comment:2 Changed 4 years ago by chapoton

  • Cc darij boussica added

bot is essentially green, please review

comment:3 Changed 4 years ago by darij

I'm not familar with the polygens construct -- how clean is it?

Also, is there a reason not to define this on the level of digraphs?

comment:4 Changed 4 years ago by tscrim

Since you also need the parent, I would do

from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
R = PolynomialRing(ZZ, 'x,y')
x,y = R.gens()

I also agree with Darij that this should be lifted to a method of DiGraph and then call self._hasse_diagram.valence_polynomial().

comment:5 Changed 4 years ago by git

  • Commit changed from 88295c7ad7c2fde67034a418983a6743835e23a8 to 96bc75877b7631305e9dd0dbbf3a8bfe1dd250a9

Branch pushed to git repo; I updated commit sha1. New commits:

96bc758trac 23165 moving the method to digraphs

comment:6 Changed 4 years ago by chapoton

done

comment:7 Changed 4 years ago by tscrim

  • Reviewers set to Darij Grinberg, Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks.

comment:8 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

pdf docs don't build

comment:9 Changed 4 years ago by git

  • Commit changed from 96bc75877b7631305e9dd0dbbf3a8bfe1dd250a9 to 5f45084a37a8053627da60a147b46610c6f2b631

Branch pushed to git repo; I updated commit sha1. New commits:

625bca1Merge branch 'u/chapoton/23165' in 8.0.b10
5f45084trac 23165 fixing pdf docbuild

comment:10 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

indeed. May be better now ?


New commits:

625bca1Merge branch 'u/chapoton/23165' in 8.0.b10
5f45084trac 23165 fixing pdf docbuild

comment:11 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

Yes, this is better.

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23165 to 5f45084a37a8053627da60a147b46610c6f2b631
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.