Changes between Version 2 and Version 5 of Ticket #23159


Ignore:
Timestamp:
06/21/17 12:23:54 (5 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23159

    • Property Status changed from new to needs_review
    • Property Authors changed from to Jeroen Demeyer
    • Property Cc nbruin kcrisman vbraun added
    • Property Branch changed from to u/jdemeyer/deprecation_from__5930_should_not_use_inspect
    • Property Commit changed from to d288f414bf0f8d785c1928fd1bdce89ec1bdc033
  • Ticket #23159 – Description

    v2 v5  
    77                deprecation(5930, "Substitution using function-call syntax and unnamed arguments is deprecated and will be removed from a future release of Sage; you can use named arguments instead, like EXPR(x=..., y=...)")
    88}}}
    9 It's not clear to me what the intent of the condition involving `inspect.ismethod` is... it was introduced in #2516.
     9The condition involving `inspect.ismethod` makes no sense to me... it was introduced in #2516.
    1010
    1111The problem is that this breaks doctests in #22747, which changes some attributes from non-methods to methods. The easiest fix is to revert this change from #2516 and unconditionally give the deprecation warning.