Opened 5 years ago

Closed 5 years ago

#23155 closed defect (duplicate)

Add Cython patches to fix various issues with binding=True

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: u/jdemeyer/ticket/23155 (Commits, GitHub, GitLab) Commit: 091657d270e422bfc7f27efa7d6944a5c3fd96f2
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Apply these two patches:

This is needed for #22747.

Change History (8)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/23155

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 2e2339b077aaa0d3cada29777d860f2c26d89f67
  • Description modified (diff)

New commits:

​2e2339bAdd Cython patch to fix decorators with binding=True

comment:3 Changed 5 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 5 years ago by git

  • Commit changed from 2e2339b077aaa0d3cada29777d860f2c26d89f67 to e09e3e0083b1a6b208299a45e3207a281deb0ed4

Branch pushed to git repo; I updated commit sha1. New commits:

​e09e3e0Add Cython patch to fix method calls with binding=True

comment:5 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Add Cython patch to fix binding=True with decorators to Add Cython patch to fix various issues with binding=True

comment:6 Changed 5 years ago by git

  • Commit changed from e09e3e0083b1a6b208299a45e3207a281deb0ed4 to 091657d270e422bfc7f27efa7d6944a5c3fd96f2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​091657dAdd Cython patch to fix method calls with binding=True

comment:7 Changed 5 years ago by jdemeyer

  • Summary changed from Add Cython patch to fix various issues with binding=True to Add Cython patches to fix various issues with binding=True

comment:8 Changed 5 years ago by jdemeyer

  • Authors Jeroen Demeyer deleted
  • Milestone changed from sage-8.0 to sage-duplicate/invalid/wontfix
  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
  • Resolution set to duplicate
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to closed

Both have been merged upstream. Given the upcoming Cython release (see #23360), I'm closing this.

Note: See TracTickets for help on using tickets.