Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#23152 closed enhancement (fixed)

Add 'is_separable' to function field class

Reported by: dbisogno Owned by:
Priority: major Milestone: sage-8.0
Component: commutative algebra Keywords: sd86.5
Cc: Merged in:
Authors: Dean Bisogno Reviewers: Édouard Rousseau, Julian Rüth
Report Upstream: N/A Work issues:
Branch: 3cbf43f (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by dbisogno)

Often necessary to check if a function field is separable before running algorithms (ie. whether it is worthwhile to look for an integral basis).

Change History (17)

comment:1 Changed 5 years ago by dbisogno

  • Branch set to u/dbisogno/add__is_separable__to_function_field_class

comment:2 Changed 5 years ago by dbisogno

  • Commit set to 4bba9ae92a1d9e298ae722f4281d5de8db77b5ac
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

4bba9aeis_separable method added to function field class

comment:3 Changed 5 years ago by dbisogno

  • Keywords sd86.5 added

comment:4 Changed 5 years ago by git

  • Commit changed from 4bba9ae92a1d9e298ae722f4281d5de8db77b5ac to 444fb594bd6470dfbfbaaf32cc6243e57705970b

Branch pushed to git repo; I updated commit sha1. New commits:

444fb59INPUT and OUTPUT blocks added to documentation.

comment:5 Changed 5 years ago by erousseau

  • Reviewers set to Edouard Rousseau
  • Status changed from needs_review to positive_review

I went through the reviewer's check list and it looks fine to me.

Edouard

comment:6 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Documentation doesn't build

comment:7 Changed 5 years ago by saraedum

  • Reviewers changed from Edouard Rousseau to Edouard Rousseau, Julian Rüth
  • Status changed from needs_work to needs_review

The sage: blocks were not indented correctly, and the math was not wrapped in single backticks (to use LaTeX style rendering.) Edouard or Dean, if you do not object to my changes, feel free to set this back to positive review.

comment:8 Changed 5 years ago by saraedum

  • Branch changed from u/dbisogno/add__is_separable__to_function_field_class to u/saraedum/add__is_separable__to_function_field_class

comment:9 Changed 5 years ago by saraedum

  • Branch changed from u/saraedum/add__is_separable__to_function_field_class to u/dbisogno/add__is_separable__to_function_field_class

I also took out the INPUT/OUTPUT blocks. They do not add anything that is not stated elsewhere already, so it's probably better to just leave them out. Feel free to put them back in, if you want them in.

comment:10 Changed 5 years ago by saraedum

  • Branch changed from u/dbisogno/add__is_separable__to_function_field_class to u/saraedum/add__is_separable__to_function_field_class

comment:11 Changed 5 years ago by erousseau

  • Commit changed from 444fb594bd6470dfbfbaaf32cc6243e57705970b to 3cbf43fc6d219172833d9bf0a5da676bcae2976f
  • Status changed from needs_review to positive_review

I do not object.

Edouard


New commits:

3cbf43fFix docbuilding errors

comment:12 Changed 5 years ago by saraedum

  • Status changed from positive_review to needs_review

comment:13 Changed 5 years ago by saraedum

I just realized that #16564 also introduces this. The implementation there is more general and apparently you need to normalize the defining polynomial to get this right?

comment:14 Changed 5 years ago by saraedum

  • Status changed from needs_review to needs_info

comment:15 Changed 5 years ago by saraedum

  • Status changed from needs_info to positive_review

Sorry for the noise. Your implementation is fine. I adapted mine to not do the normalization.

comment:16 Changed 5 years ago by vbraun

  • Branch changed from u/saraedum/add__is_separable__to_function_field_class to 3cbf43fc6d219172833d9bf0a5da676bcae2976f
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:17 Changed 5 years ago by jdemeyer

  • Commit 3cbf43fc6d219172833d9bf0a5da676bcae2976f deleted
  • Reviewers changed from Edouard Rousseau, Julian Rüth to Édouard Rousseau, Julian Rüth
Note: See TracTickets for help on using tickets.