Opened 2 years ago
Closed 2 years ago
#23137 closed enhancement (fixed)
free dendriform algebras
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  combinatorics  Keywords:  
Cc:  tscrim, darij, hivert, boussica, nthiery, VivianePons  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  22b3a6f (Commits)  Commit:  22b3a6fd4754d86cbe7cb340d2a42cce540adbc2 
Dependencies:  Stopgaps: 
Description (last modified by )
on the model of existing free preLie algebras #15635
this requires to add some methods to binary trees
Change History (16)
comment:1 Changed 2 years ago by
 Branch set to u/chapoton/23137
 Cc tscrim darij hivert added
 Commit set to 622ab02a8e5d81b1609f93974f438fe69c902a4a
 Status changed from new to needs_review
comment:2 Changed 2 years ago by
 Description modified (diff)
 Status changed from needs_review to needs_work
some doc is still lacking
comment:3 Changed 2 years ago by
 Commit changed from 622ab02a8e5d81b1609f93974f438fe69c902a4a to e094db43490b0739ba079ec620f13ac0e92dc771
Branch pushed to git repo; I updated commit sha1. New commits:
e094db4  trac 23137 some details

comment:4 Changed 2 years ago by
 Commit changed from e094db43490b0739ba079ec620f13ac0e92dc771 to 3d704c9f6c7325ab691a281888cd6a5ee8a8fc6f
Branch pushed to git repo; I updated commit sha1. New commits:
3d704c9  trac 2313µ7 caring for the doc of free dendriform algebras

comment:5 Changed 2 years ago by
 Commit changed from 3d704c9f6c7325ab691a281888cd6a5ee8a8fc6f to 756b862f13610ac957403dc7daa9bc6cab557d34
Branch pushed to git repo; I updated commit sha1. New commits:
756b862  trac 23137, some details, and adding over and under products

comment:6 Changed 2 years ago by
 Commit changed from 756b862f13610ac957403dc7daa9bc6cab557d34 to 86b52c157bd8145634107cf555b6dfd18736c874
Branch pushed to git repo; I updated commit sha1. New commits:
86b52c1  trac 23137 more doc

comment:7 Changed 2 years ago by
green bot, and should be ready for review
comment:8 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:9 Changed 2 years ago by
 Cc boussica nthiery VivianePons added
comment:10 Changed 2 years ago by
You should make sort_key
a hidden function as it serves no fundamental purpose other than for the CFM. I think it is better to spell out \prec
/\succ
rather than sub with <
/>
. Also, this should be code format:  `i`  an integer
. Otherwise, LGTM.
comment:11 Changed 2 years ago by
 Commit changed from 86b52c157bd8145634107cf555b6dfd18736c874 to a2728da53723ce5fdbff35458f2962891649cedc
Branch pushed to git repo; I updated commit sha1. New commits:
a2728da  trac 23137 reviewer's comments

comment:12 Changed 2 years ago by
 Reviewers set to Travis Scrimshaw
One last thing, you should mark those docstrings that have latex as raw r"""
(I am probably being paranoid here, but that paranoia doesn't really hurt us). Once done, you can set a positive review on my behalf.
comment:13 Changed 2 years ago by
 Commit changed from a2728da53723ce5fdbff35458f2962891649cedc to 22b3a6fd4754d86cbe7cb340d2a42cce540adbc2
Branch pushed to git repo; I updated commit sha1. New commits:
22b3a6f  trac 23137 adding r""" at some methods

comment:14 Changed 2 years ago by
done, thanks. I have relaunched my bot to check that doc builds.
comment:15 Changed 2 years ago by
 Status changed from needs_review to positive_review
Thanks again, Travis. I am setting to positive.
comment:16 Changed 2 years ago by
 Branch changed from u/chapoton/23137 to 22b3a6fd4754d86cbe7cb340d2a42cce540adbc2
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
free dendriform algebras