Opened 6 years ago
Closed 5 years ago
#23137 closed enhancement (fixed)
free dendriform algebras
Reported by:  Frédéric Chapoton  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  combinatorics  Keywords:  
Cc:  Travis Scrimshaw, Darij Grinberg, Florent Hivert, Adrien Boussicault, Nicolas M. Thiéry, Viviane Pons  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  22b3a6f (Commits, GitHub, GitLab)  Commit:  22b3a6fd4754d86cbe7cb340d2a42cce540adbc2 
Dependencies:  Stopgaps: 
Description (last modified by )
on the model of existing free preLie algebras #15635
this requires to add some methods to binary trees
Change History (16)
comment:1 Changed 6 years ago by
Branch:  → u/chapoton/23137 

Cc:  Travis Scrimshaw Darij Grinberg Florent Hivert added 
Commit:  → 622ab02a8e5d81b1609f93974f438fe69c902a4a 
Status:  new → needs_review 
comment:2 Changed 6 years ago by
Description:  modified (diff) 

Status:  needs_review → needs_work 
some doc is still lacking
comment:3 Changed 6 years ago by
Commit:  622ab02a8e5d81b1609f93974f438fe69c902a4a → e094db43490b0739ba079ec620f13ac0e92dc771 

Branch pushed to git repo; I updated commit sha1. New commits:
e094db4  trac 23137 some details

comment:4 Changed 6 years ago by
Commit:  e094db43490b0739ba079ec620f13ac0e92dc771 → 3d704c9f6c7325ab691a281888cd6a5ee8a8fc6f 

Branch pushed to git repo; I updated commit sha1. New commits:
3d704c9  trac 2313µ7 caring for the doc of free dendriform algebras

comment:5 Changed 6 years ago by
Commit:  3d704c9f6c7325ab691a281888cd6a5ee8a8fc6f → 756b862f13610ac957403dc7daa9bc6cab557d34 

Branch pushed to git repo; I updated commit sha1. New commits:
756b862  trac 23137, some details, and adding over and under products

comment:6 Changed 6 years ago by
Commit:  756b862f13610ac957403dc7daa9bc6cab557d34 → 86b52c157bd8145634107cf555b6dfd18736c874 

Branch pushed to git repo; I updated commit sha1. New commits:
86b52c1  trac 23137 more doc

comment:8 Changed 6 years ago by
Status:  needs_work → needs_review 

comment:9 Changed 6 years ago by
Cc:  Adrien Boussicault Nicolas M. Thiéry Viviane Pons added 

comment:10 Changed 6 years ago by
You should make sort_key
a hidden function as it serves no fundamental purpose other than for the CFM. I think it is better to spell out \prec
/\succ
rather than sub with <
/>
. Also, this should be code format:  `i`  an integer
. Otherwise, LGTM.
comment:11 Changed 6 years ago by
Commit:  86b52c157bd8145634107cf555b6dfd18736c874 → a2728da53723ce5fdbff35458f2962891649cedc 

Branch pushed to git repo; I updated commit sha1. New commits:
a2728da  trac 23137 reviewer's comments

comment:12 Changed 6 years ago by
Reviewers:  → Travis Scrimshaw 

One last thing, you should mark those docstrings that have latex as raw r"""
(I am probably being paranoid here, but that paranoia doesn't really hurt us). Once done, you can set a positive review on my behalf.
comment:13 Changed 6 years ago by
Commit:  a2728da53723ce5fdbff35458f2962891649cedc → 22b3a6fd4754d86cbe7cb340d2a42cce540adbc2 

Branch pushed to git repo; I updated commit sha1. New commits:
22b3a6f  trac 23137 adding r""" at some methods

comment:15 Changed 6 years ago by
Status:  needs_review → positive_review 

Thanks again, Travis. I am setting to positive.
comment:16 Changed 5 years ago by
Branch:  u/chapoton/23137 → 22b3a6fd4754d86cbe7cb340d2a42cce540adbc2 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
free dendriform algebras