Opened 2 years ago

Closed 21 months ago

#23135 closed defect (fixed)

Doctest: Conjugate does not distribute over a sum

Reported by: mforets Owned by:
Priority: major Milestone: sage-8.0
Component: symbolics Keywords: assumptions, complex numbers
Cc: rws Merged in:
Authors: Ralf Stephan Reviewers: Marcelo Forets
Report Upstream: N/A Work issues:
Branch: 8cef176 (Commits) Commit: 8cef17614aefcdbd928915e2b39c5111acfa9a3d
Dependencies: #23325 Stopgaps:

Description 

sage: x = var('x', domain='real') 
sage: conjugate(x+I)
x + I
sage: conjugate(x)+conjugate(I)
x - I

(tested on top of #23134)

Reported recently in ask.sagemath, ​a problem with variables in real domains

Change History (8)

comment:1 Changed 2 years ago by rws

  • Dependencies set to pynac-0.7.9
  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.

A rarely visited part of the Pynac code tried to be too smart. Fixed in pynac master.

comment:2 follow-up: Changed 2 years ago by hwsmith

So will this problem be solved once SageMath is using pynac master? If so should we close this ticket?

comment:3 in reply to: ↑ 2 Changed 2 years ago by rws

Replying to hwsmith:

So will this problem be solved once SageMath is using pynac master? If so should we close this ticket?

The dependency on "pynac-0.7.9" will be replaced with the Pynac upgrade ticket number after that version was released. This ticket should add doctests for the issue. Usually its title is then prepended with "Doctest:" to give a hint to potential reviewers.

comment:4 Changed 2 years ago by rws

  • Dependencies changed from pynac-0.7.9 to #23325
  • Report Upstream changed from Fixed upstream, in a later stable release. to N/A

comment:5 Changed 21 months ago by rws

  • Branch set to u/rws/conjugate_does_not_distribute_over_a_sum

comment:6 Changed 21 months ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 8cef17614aefcdbd928915e2b39c5111acfa9a3d
  • Status changed from new to needs_review
  • Summary changed from Conjugate does not distribute over a sum to Doctest: Conjugate does not distribute over a sum

New commits:

​8cef17623135: Doctest: Conjugate does not distribute over a sum

comment:7 Changed 21 months ago by mforets

  • Reviewers set to Marcelo Forets
  • Status changed from needs_review to positive_review

reviewed. thank you for fixing this!

comment:8 Changed 21 months ago by vbraun

  • Branch changed from u/rws/conjugate_does_not_distribute_over_a_sum to 8cef17614aefcdbd928915e2b39c5111acfa9a3d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.