Opened 5 years ago

Closed 5 years ago

#23135 closed defect (fixed)

Doctest: Conjugate does not distribute over a sum

Reported by: Marcelo Forets Owned by:
Priority: major Milestone: sage-8.0
Component: symbolics Keywords: assumptions, complex numbers
Cc: Ralf Stephan Merged in:
Authors: Ralf Stephan Reviewers: Marcelo Forets
Report Upstream: N/A Work issues:
Branch: 8cef176 (Commits, GitHub, GitLab) Commit: 8cef17614aefcdbd928915e2b39c5111acfa9a3d
Dependencies: #23325 Stopgaps:

Status badges

Description

sage: x = var('x', domain='real') 
sage: conjugate(x+I)
x + I
sage: conjugate(x)+conjugate(I)
x - I

(tested on top of #23134)

Reported recently in ask.sagemath, a problem with variables in real domains

Change History (8)

comment:1 Changed 5 years ago by Ralf Stephan

Dependencies: pynac-0.7.9
Report Upstream: N/AFixed upstream, in a later stable release.

A rarely visited part of the Pynac code tried to be too smart. Fixed in pynac master.

comment:2 Changed 5 years ago by Hanson Smith

So will this problem be solved once SageMath is using pynac master? If so should we close this ticket?

comment:3 in reply to:  2 Changed 5 years ago by Ralf Stephan

Replying to hwsmith:

So will this problem be solved once SageMath is using pynac master? If so should we close this ticket?

The dependency on "pynac-0.7.9" will be replaced with the Pynac upgrade ticket number after that version was released. This ticket should add doctests for the issue. Usually its title is then prepended with "Doctest:" to give a hint to potential reviewers.

comment:4 Changed 5 years ago by Ralf Stephan

Dependencies: pynac-0.7.9#23325
Report Upstream: Fixed upstream, in a later stable release.N/A

comment:5 Changed 5 years ago by Ralf Stephan

Branch: u/rws/conjugate_does_not_distribute_over_a_sum

comment:6 Changed 5 years ago by Ralf Stephan

Authors: Ralf Stephan
Commit: 8cef17614aefcdbd928915e2b39c5111acfa9a3d
Status: newneeds_review
Summary: Conjugate does not distribute over a sumDoctest: Conjugate does not distribute over a sum

New commits:

8cef17623135: Doctest: Conjugate does not distribute over a sum

comment:7 Changed 5 years ago by Marcelo Forets

Reviewers: Marcelo Forets
Status: needs_reviewpositive_review

reviewed. thank you for fixing this!

comment:8 Changed 5 years ago by Volker Braun

Branch: u/rws/conjugate_does_not_distribute_over_a_sum8cef17614aefcdbd928915e2b39c5111acfa9a3d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.