Opened 3 years ago

Closed 3 years ago

#23130 closed enhancement (fixed)

py3: some care for map in various places

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: tscrim, jmantysalo, jhpalmieri Merged in:
Authors: Frédéric Chapoton Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 77233e1 (Commits) Commit: 77233e1481e8a22699889e863f0e0bb68e47ce83
Dependencies: Stopgaps:

Description

part of #16073

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/23130
  • Commit set to 764d0587f3b1231890d6af43a6c622f21be7d251

New commits:

764d058py3: some care for map

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim jmantysalo jhpalmieri added
  • Status changed from new to needs_review

comment:3 Changed 3 years ago by jhpalmieri

Regarding from six.moves import range as range, can we just say from six.moves import range? I see that in many places in the Sage library (cluster_algebra.py is the only place I see import range as range.)

comment:4 Changed 3 years ago by git

  • Commit changed from 764d0587f3b1231890d6af43a6c622f21be7d251 to 77233e1481e8a22699889e863f0e0bb68e47ce83

Branch pushed to git repo; I updated commit sha1. New commits:

77233e1trac 23130 fixing strange range import

comment:5 Changed 3 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Okay, looks good.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/23130 to 77233e1481e8a22699889e863f0e0bb68e47ce83
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.