Changes between Initial Version and Version 1 of Ticket #23107, comment 29


Ignore:
Timestamp:
06/07/17 12:32:03 (5 years ago)
Author:
tscrim
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23107, comment 29

    initial v1  
    1 What has happened is you have introduced a regression in terms of support with changes like this:
     1What has happened is you have increased support with changes like this:
    22{{{#!diff
    33diff --git a/src/sage/matrix/matrix1.pyx b/src/sage/matrix/matrix1.pyx
     
    1919 
    2020}}}
    21 which is why you now need to explicitly specify it as a list. By allowing an `xrange` (which is Cython-speak for Python3 range) input, you are Python3 compatible. So I don't fundamentally see my and Jeroen's objections as being different (actually, mine was more meant as a question at the time).
     21and you do not need to explicitly specify it as a list. By allowing an `xrange` (which is Cython-speak for Python3 range) input, you are Python3 compatible. So I don't fundamentally see my and Jeroen's objections as being different (actually, mine was more meant as a question at the time).
     22
     23Edit: Misread the code, it is not a regression but an expansion of support.