Opened 5 years ago

Closed 5 years ago

#23103 closed enhancement (fixed)

Move richcmp stuff to new file

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: misc Keywords:
Cc: chapoton, tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 031761f (Commits, GitHub, GitLab) Commit: 031761f6ead116e4fa0a0fd3bf21fca5546df6d7
Dependencies: Stopgaps:

Status badges

Description

The file src/sage/structure/sage_object.pyx contains a lot of stuff to deal with rich comparisons. Given that more of this will be added in #23102, I suggest to create a new file src/sage/structure/richcmp.pyx for this.

Change History (11)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/move_richcmp_stuff_to_new_file

comment:2 Changed 5 years ago by chapoton

  • Commit set to 7871f542977f6c9168214ae6204da42349153043

ok if patchbot gives a green light

New commits:

​7871f54Move richcmp stuff to new file richcmp.pyx

comment:3 Changed 5 years ago by jdemeyer

This isn't ready yet. I'll push an update soon.

comment:4 Changed 5 years ago by tscrim

  • Cc tscrim added

+1

comment:5 Changed 5 years ago by git

  • Commit changed from 7871f542977f6c9168214ae6204da42349153043 to 256bf191ab0472303bb11e105a246106e894c4ec

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​256bf19Move richcmp stuff to new file richcmp.pyx

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from new to needs_review

comment:7 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good enough. Let it be.

comment:8 Changed 5 years ago by jdemeyer

  • Status changed from positive_review to needs_work

This needs an update for 8.0.beta9

comment:9 Changed 5 years ago by git

  • Commit changed from 256bf191ab0472303bb11e105a246106e894c4ec to 031761f6ead116e4fa0a0fd3bf21fca5546df6d7

Branch pushed to git repo; I updated commit sha1. New commits:

​7629851Merge tag '8.0.beta9' into t/23103/move_richcmp_stuff_to_new_file
​031761fFix two more imports

comment:10 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to positive_review

The fixes are totally trivial, so I'm setting this back to positive_review.

comment:11 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/move_richcmp_stuff_to_new_file to 031761f6ead116e4fa0a0fd3bf21fca5546df6d7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.