Opened 10 months ago
Closed 9 months ago
#23086 closed defect (fixed)
cyclegraph for Projective Morphisms
Reported by:  bbarros  Owned by:  

Priority:  minor  Milestone:  sage8.0 
Component:  algebraic geometry  Keywords:  cyclegraph, dynamics, projective, morphisms 
Cc:  Merged in:  
Authors:  Ben Barros  Reviewers:  Ben Hutz, Ben Barros 
Report Upstream:  N/A  Work issues:  
Branch:  841eb46 (Commits)  Commit:  841eb465f0319ebedd6261e33a8fbcb48206766b 
Dependencies:  Stopgaps: 
Description
The cyclegraph() function for Projective Morphisms raises a value error whenever a function has indeterminacy points. I will fix this by adding an exception for value errors.
Change History (9)
comment:1 Changed 10 months ago by
 Branch set to u/bbarros/23086
comment:2 Changed 10 months ago by
 Branch u/bbarros/23086 deleted
comment:3 Changed 10 months ago by
 Branch set to u/bbarros/23086
comment:4 Changed 10 months ago by
 Commit set to 608822997c882a615a63ada773d91f2ea6316980
comment:5 Changed 10 months ago by
 Branch changed from u/bbarros/23086 to u/bhutz/23086
comment:6 Changed 10 months ago by
 Cc bhutz removed
 Commit changed from 608822997c882a615a63ada773d91f2ea6316980 to 28dea8ce9a2437f4e3259878337d8ad5f0a7edbf
 Component changed from number fields to algebraic geometry
 Reviewers set to Ben Hutz
 Status changed from new to needs_review
A couple procedural things:
 the red branch names means there is a merge conflict. It is best to work based off of more recent beta.
 you should start the merge commit with the ticket number
 you should change it to needsreview when you're ready.
 tests should be as fast as possible unless there is a good reason for a longer test. So I changed the base field for one of your tests
I also made a couple changes
 I fixed the merge conflict
 I fixed the spacing (you had an extra tab everywhere)
 the subscheme case didn't work.
I'll change it to needsreview, but after you pull, test, and approve my changes, you can switch it to positive.
New commits:
0dce604  Merge branch 8.0beta7 into t/23086/23086

28dea8c  23086: fixed spacing and subscheme case

comment:7 Changed 10 months ago by
 Commit changed from 28dea8ce9a2437f4e3259878337d8ad5f0a7edbf to 841eb465f0319ebedd6261e33a8fbcb48206766b
Branch pushed to git repo; I updated commit sha1. New commits:
841eb46  23086: removed untracked files

comment:8 Changed 10 months ago by
 Reviewers changed from Ben Hutz to Ben Hutz, Ben Barros
 Status changed from needs_review to positive_review
All doctests passed. Looks good to me.
comment:9 Changed 9 months ago by
 Branch changed from u/bhutz/23086 to 841eb465f0319ebedd6261e33a8fbcb48206766b
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
Fixed cyclegraph() bug to allow indeterminacy pts