Opened 5 years ago

Closed 5 years ago

#23086 closed defect (fixed)

cyclegraph for Projective Morphisms

Reported by: Benjamin Barros Owned by:
Priority: minor Milestone: sage-8.0
Component: algebraic geometry Keywords: cyclegraph, dynamics, projective, morphisms
Cc: Merged in:
Authors: Ben Barros Reviewers: Ben Hutz, Ben Barros
Report Upstream: N/A Work issues:
Branch: 841eb46 (Commits, GitHub, GitLab) Commit: 841eb465f0319ebedd6261e33a8fbcb48206766b
Dependencies: Stopgaps:

Status badges

Description

The cyclegraph() function for Projective Morphisms raises a value error whenever a function has indeterminacy points. I will fix this by adding an exception for value errors.

Change History (9)

comment:1 Changed 5 years ago by Benjamin Barros

Branch: u/bbarros/23086

comment:2 Changed 5 years ago by Benjamin Barros

Branch: u/bbarros/23086

comment:3 Changed 5 years ago by Benjamin Barros

Branch: u/bbarros/23086

comment:4 Changed 5 years ago by git

Commit: 608822997c882a615a63ada773d91f2ea6316980

Branch pushed to git repo; I updated commit sha1. New commits:

6088229Fixed cyclegraph() bug to allow indeterminacy pts

comment:5 Changed 5 years ago by Ben Hutz

Branch: u/bbarros/23086u/bhutz/23086

comment:6 Changed 5 years ago by Ben Hutz

Cc: Ben Hutz removed
Commit: 608822997c882a615a63ada773d91f2ea631698028dea8ce9a2437f4e3259878337d8ad5f0a7edbf
Component: number fieldsalgebraic geometry
Reviewers: Ben Hutz
Status: newneeds_review

A couple procedural things:

  • the red branch names means there is a merge conflict. It is best to work based off of more recent beta.
  • you should start the merge commit with the ticket number
  • you should change it to needs-review when you're ready.
  • tests should be as fast as possible unless there is a good reason for a longer test. So I changed the base field for one of your tests

I also made a couple changes

  • I fixed the merge conflict
  • I fixed the spacing (you had an extra tab everywhere)
  • the subscheme case didn't work.

I'll change it to needs-review, but after you pull, test, and approve my changes, you can switch it to positive.


New commits:

0dce604Merge branch 8.0beta7 into t/23086/23086
28dea8c23086: fixed spacing and subscheme case

comment:7 Changed 5 years ago by git

Commit: 28dea8ce9a2437f4e3259878337d8ad5f0a7edbf841eb465f0319ebedd6261e33a8fbcb48206766b

Branch pushed to git repo; I updated commit sha1. New commits:

841eb4623086: removed untracked files

comment:8 Changed 5 years ago by Benjamin Barros

Reviewers: Ben HutzBen Hutz, Ben Barros
Status: needs_reviewpositive_review

All doctests passed. Looks good to me.

comment:9 Changed 5 years ago by Volker Braun

Branch: u/bhutz/23086841eb465f0319ebedd6261e33a8fbcb48206766b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.