Opened 5 years ago

Closed 5 years ago

#23084 closed enhancement (fixed)

py3: some care for map inside ETuple

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: Nils Bruin Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c405fc0 (Commits, GitHub, GitLab) Commit: c405fc0bd48f2099da5274dd6adba84efd9a0ef4
Dependencies: Stopgaps:

Status badges

Description

part of #16073

Change History (6)

comment:1 Changed 5 years ago by Frédéric Chapoton

Branch: u/chapoton/23084
Cc: Nils Bruin added
Commit: c011cfada9c95d0ded5057c8e88b1b1cfd9d7d31
Status: newneeds_review

comment:2 Changed 5 years ago by git

Commit: c011cfada9c95d0ded5057c8e88b1b1cfd9d7d31401032f8f9153e9eb531c8977f956d219f00eb64

Branch pushed to git repo; I updated commit sha1. New commits:

401032ffixing ETuple(map for python3

comment:3 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

Nitpick, but I feel like your ETuple error should have a closing parenthesis ). Otherwise LGTM and can set positive review on my behalf.

comment:4 Changed 5 years ago by git

Commit: 401032f8f9153e9eb531c8977f956d219f00eb64c405fc0bd48f2099da5274dd6adba84efd9a0ef4

Branch pushed to git repo; I updated commit sha1. New commits:

c405fc0trac 23084 adding missing parenthesis

comment:5 Changed 5 years ago by Frédéric Chapoton

Status: needs_reviewpositive_review

done, thanks. Setting to positive

comment:6 Changed 5 years ago by Volker Braun

Branch: u/chapoton/23084c405fc0bd48f2099da5274dd6adba84efd9a0ef4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.