Opened 3 years ago

Closed 3 years ago

#23084 closed enhancement (fixed)

py3: some care for map inside ETuple

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: nbruin Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c405fc0 (Commits) Commit: c405fc0bd48f2099da5274dd6adba84efd9a0ef4
Dependencies: Stopgaps:

Description

part of #16073

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/23084
  • Cc nbruin added
  • Commit set to c011cfada9c95d0ded5057c8e88b1b1cfd9d7d31
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by git

  • Commit changed from c011cfada9c95d0ded5057c8e88b1b1cfd9d7d31 to 401032f8f9153e9eb531c8977f956d219f00eb64

Branch pushed to git repo; I updated commit sha1. New commits:

401032ffixing ETuple(map for python3

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Nitpick, but I feel like your ETuple error should have a closing parenthesis ). Otherwise LGTM and can set positive review on my behalf.

comment:4 Changed 3 years ago by git

  • Commit changed from 401032f8f9153e9eb531c8977f956d219f00eb64 to c405fc0bd48f2099da5274dd6adba84efd9a0ef4

Branch pushed to git repo; I updated commit sha1. New commits:

c405fc0trac 23084 adding missing parenthesis

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

done, thanks. Setting to positive

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/23084 to c405fc0bd48f2099da5274dd6adba84efd9a0ef4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.