Opened 4 years ago

Closed 4 years ago

#23064 closed enhancement (fixed)

cleanup of weierstrass_morphism.py (pep8 and cmp)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: elliptic curves Keywords:
Cc: cremona, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 0cd6a64 (Commits, GitHub, GitLab) Commit: 0cd6a64f2ffbbc9a78bab0302671b2a515a22e7c
Dependencies: Stopgaps:

Status badges

Description

refresh this file, mainly to pep8 standard

and change comparison towards py3

Change History (5)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/23064
  • Commit set to 0cd6a64f2ffbbc9a78bab0302671b2a515a22e7c
  • Status changed from new to needs_review

New commits:

0cd6a64cleanup of weierstrass_morphism (pep8, cmp)

comment:2 Changed 4 years ago by chapoton

  • Cc cremona jdemeyer added

Patchbot is essentially green. Please review.

comment:3 Changed 4 years ago by cremona

As far as I can see almost all the changes are cosmetic / white space in code or docstrings, which I am quite happy with. (I think I wrote a lot of the affected code in 2007 as my very first contribution to Sage.) As long as the docs build with no errors and look OK, I am happy with all that,. As for the new-style comparison code, if the tests still pass then I am happy with that too.

comment:4 Changed 4 years ago by chapoton

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

Thank you, John.

Patchbot is green, so all doctests pass and doc builds. I am therefore setting to positive review.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/23064 to 0cd6a64f2ffbbc9a78bab0302671b2a515a22e7c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.