Opened 3 years ago

Closed 3 years ago

#23059 closed defect (fixed)

Fix Python 2 build on Cygwin

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.0
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 609393a (Commits) Commit: 609393ad73188016b15137552dc6e481886686ff
Dependencies: Stopgaps:

Description

This commit broke the build of Python 2 on Cygwin by moving the definition of the PYTHON_VERSION variable used for the Cygwin install as well as OSX.

I didn't notice before since I was just doing incremental builds.

Change History (6)

comment:1 Changed 3 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/cygwin/ticket-23059
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by git

  • Commit set to 609393ad73188016b15137552dc6e481886686ff

Branch pushed to git repo; I updated commit sha1. New commits:

609393aRoll back accidental change from dc46ea2dfa97be79d7ef8ddbe9130d4c717acc3d that broke build of Python 2 on Cygwin.

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by jhpalmieri

Sorry, that was a silly mistake on my part.

comment:5 Changed 3 years ago by embray

No problem!

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/embray/cygwin/ticket-23059 to 609393ad73188016b15137552dc6e481886686ff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.