Opened 4 years ago

Closed 3 years ago

#23054 closed defect (fixed)

remove hardcoded gcc in gap_packages

Reported by: dimpase Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords: clang
Cc: fbissey, tscrim Merged in:
Authors: Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Currently at least in guava, a part of gap_packages, there is a hardcoded gcc in some makefiles.

[gap_packages-4.8.6.p2] make[2]: Entering directory '/usr/home/dima/Sage/sage/local/gap/gap-4.8.6/pkg/guava-3.13'
[gap_packages-4.8.6.p2] make[2]: warning: -jN forced in submake: disabling jobserver mode.
[gap_packages-4.8.6.p2] if test ! -d bin/amd64-unknown-freebsd11.0-clang-devel-default64;  then mkdir -p bin/amd64-unknown-freebsd11.0-clang-devel-default64;  fi
[gap_packages-4.8.6.p2] gcc -O2   -c -o src/ctjhai/minimum-weight.o src/ctjhai/minimum-weight.c
[gap_packages-4.8.6.p2] make[2]: gcc: Command not found

As well, I see in grape log there

[gap_packages-4.8.6.p2] checking host system type... Invalid configuration `amd64-unknown-freebsd11.0': machine `amd64-unknown' not recognized

but this is otherwise seemingly harmless.

Change History (8)

comment:1 Changed 4 years ago by dimpase

  • Cc fbissey added

comment:2 Changed 4 years ago by tscrim

  • Cc tscrim added

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.0 to sage-8.6

This issue would be fixed by #26856.

comment:4 Changed 3 years ago by dimpase

  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.

fixed, or at least updated. In fact I fixed these things in guava upstream lately, but they have not yet made it into new GAP.

comment:5 Changed 3 years ago by dimpase

  • Report Upstream changed from Fixed upstream, but not in a stable release. to N/A
  • Status changed from new to needs_review

comment:6 Changed 3 years ago by dimpase

  • Milestone changed from sage-8.6 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

yes, this will be fixed by #26856 - I backported the upstream fix, in fact, just forgot about it already.

comment:7 Changed 3 years ago by dimpase

  • Reviewers set to Dima Pasechnik

comment:8 Changed 3 years ago by embray

  • Resolution set to fixed
  • Status changed from positive_review to closed

Fixed by #26856. Hurrah for incidentally fixing 20 month old issues.

Note: See TracTickets for help on using tickets.