Opened 4 years ago

Closed 7 months ago

#23010 closed enhancement (duplicate)

Move Parent.construction to the Sets.ParentMethods, and categorify three more parents

Reported by: nthiery Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: categories Keywords:
Cc: tscrim, SimonKing Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by nthiery)

Moving the default implementation Parent.construction (which just returns None) to Sets.ParentMethods enables categories to provide an implementation when relevant.

This ticket also fixes QuaternionAlgebra?, QuaternionOrder?, LazyPowerSeriesRing? and MPCComplexField whose categories were not properly initialized (and as a consequence they did not inherit anymore the construction method)

See also: #21380

Change History (9)

comment:1 Changed 4 years ago by nthiery

  • Branch set to u/nthiery/move_parent_construction_to_the_sets_parentmethods__and_categorify_three_more_parents

comment:2 Changed 4 years ago by nthiery

  • Commit set to 1a13892ae28888fe6fdd68504af0ff7fc30bf16f
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

acd9af323010: Lift Parent.construction to Sets.ParentMethods
fe1a0c223010: categorification of QuaternionAlgebra and QuaternionOrder
27f756f23010: Categorification of MPCComplexField
1a1389223010: Categorification of LazyPowerSeriesRing

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Docs dont build

comment:5 Changed 8 months ago by mkoeppe

  • Milestone changed from sage-8.0 to sage-9.2

comment:6 Changed 8 months ago by chapoton

  • Branch changed from u/nthiery/move_parent_construction_to_the_sets_parentmethods__and_categorify_three_more_parents to public/ticket/23010
  • Commit changed from 1a13892ae28888fe6fdd68504af0ff7fc30bf16f to 99aa8addde9c81b06b5372ea73c2d5580c2f4965

too bad to let this bit-rot just because of a documentation problem.


New commits:

99aa8adMerge branch 'u/nthiery/move_parent_construction_to_the_sets_parentmethods__and_categorify_three_more_parents' in 9.2.beta8

comment:7 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

These commits seem to have been merged already through other tickets. Nothing left to be done.

comment:8 Changed 7 months ago by tscrim

  • Authors Nicolas M. Thiéry deleted
  • Branch public/ticket/23010 deleted
  • Commit 99aa8addde9c81b06b5372ea73c2d5580c2f4965 deleted
  • Status changed from needs_review to positive_review

Yes, indeed.

comment:9 Changed 7 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.