Opened 4 years ago

Closed 4 years ago

#23001 closed defect (fixed)

Implement is_NaN for all rings with NaN elements

Reported by: rws Owned by:
Priority: major Milestone: sage-8.0
Component: numerical Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 920e5ad (Commits, GitHub, GitLab) Commit: 920e5adcf6628c15f484e9f28bc970e3e2c96fe9
Dependencies: Stopgaps:

Status badges

Description (last modified by rws)

Elements of the following rings can't be checked for NaN:

  • CC (RR can)
  • CDF (RDF can)
  • CIF (RIF can)
  • Ball fields

Other rings don't have NaN so there is no need for them.

The ticket might add back-conversions from complex NaN to real NaN (which should always be possible).

Change History (10)

comment:1 Changed 4 years ago by rws

  • Description modified (diff)

comment:2 Changed 4 years ago by rws

  • Branch set to u/rws/implement_is_nan_for_all_rings_with_nan_elements

comment:3 Changed 4 years ago by git

  • Commit set to 5f8b7030bb0bd7b17d87a1c957bdb1d290aae034

Branch pushed to git repo; I updated commit sha1. New commits:

ca839ea23001: is_NaN for ball fields
5f8b70323001: NaN back-conversion with interval fields

comment:4 Changed 4 years ago by rws

  • Authors set to Ralf Stephan
  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 4 years ago by git

  • Commit changed from 5f8b7030bb0bd7b17d87a1c957bdb1d290aae034 to 920e5adcf6628c15f484e9f28bc970e3e2c96fe9
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

920e5ad23001: Back-convert complex NaN (NaN+NaN*I) to the resp. real field

comment:7 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by rws

Thanks. Oops, I had some additions after your comments.

comment:9 Changed 4 years ago by tscrim

No problem, they were easy enough to recheck.

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/rws/implement_is_nan_for_all_rings_with_nan_elements to 920e5adcf6628c15f484e9f28bc970e3e2c96fe9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.