Changes between Version 11 and Version 21 of Ticket #22984


Ignore:
Timestamp:
03/04/18 22:42:12 (4 years ago)
Author:
tscrim
Comment:

Replying to Winfried:

The problem is solved. Replace line 323 of source/libnormaliz/sublattice_representation.h

by

    if(Vertices.nr_of_rows()==0 || Vertices.rank()<EmbDim){ // use Supps for LLL coordinates

i.e., delete "-1" in this line.

Great, thank you for figuring it out. I am guessing you are in the process of making a commit upstream or should I do a pull request?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22984

    • Property Status changed from needs_review to needs_work
    • Property Reviewers changed from to Travis Scrimshaw, Thierry Monteil
    • Property Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.
    • Property Commit changed from f2137cc5bb49278657ce23f0f8c775400b494023 to b8f7abc04085155225e54ad168ce4a7884fdd6cf
  • Ticket #22984 – Description

    v11 v21  
    44 - https://github.com/Normaliz/Normaliz/releases/download/v3.5.1/normaliz-3.5.1.tar.gz
    55 - https://pypi.python.org/packages/47/99/c9043d8392f99c9c4013eb82ce931f75ef64d6fd665cd8d008ce80be881e/PyNormaliz-1.10.tar.gz#md5=89b212de8e833205b9776b1ef90c3585
     6
     7Upstream bug: https://github.com/Normaliz/Normaliz/issues/176