Opened 4 years ago

Closed 4 years ago

#22975 closed enhancement (fixed)

py3: some absolute import in pyx files

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e41a512 (Commits, GitHub, GitLab) Commit: e41a5125373660ea215dc5d24664acd5c913afdb
Dependencies: Stopgaps:

Status badges

Description

part of #22808

Change History (15)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22975
  • Commit set to 2aca10e42eab75fdab0dcd4e8aeecd8941a3f51e
  • Status changed from new to needs_review

New commits:

2aca10epy3: some absolute_import added in pyx files

comment:2 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:3 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

See patchbot

comment:4 Changed 4 years ago by git

  • Commit changed from 2aca10e42eab75fdab0dcd4e8aeecd8941a3f51e to cdb94bbf5722c7a2c95ab3be48ffd6cf53b7df79

Branch pushed to git repo; I updated commit sha1. New commits:

1ef6d04Merge branch 'u/chapoton/22975' in 8.0.b6
cdb94bbtrac 22975 oops, typo

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:6 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

ok,I allow myself to set this back to positive

comment:7 Changed 4 years ago by fbissey

Well, I am still seeing the stuff shown on the build bot. Should it be import .matrix_misc instead of import matrix_misc in sage/matrix/matrix0.pyx?

comment:8 Changed 4 years ago by chapoton

  • Status changed from positive_review to needs_work

oops

comment:9 Changed 4 years ago by git

  • Commit changed from cdb94bbf5722c7a2c95ab3be48ffd6cf53b7df79 to 5032c36e4c5c23e5f2775aa82aa0c315f7c3cce0

Branch pushed to git repo; I updated commit sha1. New commits:

ec5eecbMerge branch 'u/chapoton/22975' in 8.0.b7
5032c36trac 22975 one more relative import

comment:10 Changed 4 years ago by git

  • Commit changed from 5032c36e4c5c23e5f2775aa82aa0c315f7c3cce0 to f8cffe4140b81f8887b030a697cd6c084ed0bbf6

Branch pushed to git repo; I updated commit sha1. New commits:

f8cffe4trac 22975 fixing some absolute imports

comment:11 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

should be good now, let us wait for the bots

comment:12 Changed 4 years ago by git

  • Commit changed from f8cffe4140b81f8887b030a697cd6c084ed0bbf6 to e41a5125373660ea215dc5d24664acd5c913afdb

Branch pushed to git repo; I updated commit sha1. New commits:

e41a512trac 22975 fixing 3 other imports

comment:13 Changed 4 years ago by chapoton

ok, green bot at last. Please review.

comment:14 Changed 4 years ago by fbissey

  • Status changed from needs_review to positive_review

My pleasure.

comment:15 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/22975 to e41a5125373660ea215dc5d24664acd5c913afdb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.