Opened 4 years ago

Closed 4 years ago

#22952 closed defect (fixed)

Trivial failure in py3_syntax test

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.0
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: fcee19c (Commits, GitHub, GitLab) Commit: fcee19cbf6606f7676cbabcc44ee8d539b440b33
Dependencies: Stopgaps:

Status badges


The test from #22357 fails if the test suit is run from outside SAGE_ROOT:

sage -t --long /opt/sage/src/sage/tests/
File "/opt/sage/src/sage/tests/", line 79, in sage.tests.py3_syntax.SortedDirectoryWalkerABC.__iter__
Failed example:
    ('src/sage/tests/french_book', 'README', '')
    ('../../opt/sage/src/sage/tests/french_book', 'README', '')
1 item had failures:
   1 of   4 in sage.tests.py3_syntax.SortedDirectoryWalkerABC.__iter__
    [29 tests, 1 failure, 12.77 s]

Obviously the test just needs some ellipses.

Change History (4)

comment:1 Changed 4 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/22952
  • Commit set to fcee19cbf6606f7676cbabcc44ee8d539b440b33
  • Status changed from new to needs_review

done, please review

New commits:

fcee19ctrac 22952 adding ellipses

comment:2 Changed 4 years ago by embray

  • Status changed from needs_review to positive_review

That looks right--thanks.

comment:3 Changed 4 years ago by embray

  • Reviewers set to Erik Bray

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/22952 to fcee19cbf6606f7676cbabcc44ee8d539b440b33
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.