Opened 5 years ago

Closed 5 years ago

#22949 closed enhancement (fixed)

Add a method to contruct a finite-dimensional Lie algebra as a FiniteDimensionalAlgebra

Reported by: tscrim Owned by:
Priority: major Milestone: sage-8.0
Component: algebra Keywords: lie algebras
Cc: Merged in:
Authors: Travis Scrimshaw Reviewers: Ben Salisbury
Report Upstream: N/A Work issues:
Branch: 6c67860 (Commits, GitHub, GitLab) Commit: 6c67860eb81580cd698b851a6141c4bb871b9906
Dependencies: Stopgaps:

Status badges

Description

It's good to have such conversions, and it allows users to use multiplicative notation for Lie brackets.

Change History (6)

comment:1 Changed 5 years ago by tscrim

  • Branch set to public/lie_algebras/as_fin_dim_algebra-22949
  • Commit set to cc01e48bf8dfcc9f1602a3a07f75aedb066b2f47
  • Status changed from new to needs_review

New commits:

​cc01e48Adding code to change the finite dimensional Lie algebra into a FiniteDimensionalAlgebra.

comment:2 Changed 5 years ago by tscrim

  • Keywords lie algebras added

comment:3 Changed 5 years ago by bsalisbury1

  • Reviewers set to Ben Salisbury
  • Status changed from needs_review to positive_review

Looks good, everything builds and all tests pass.

comment:4 Changed 5 years ago by git

  • Commit changed from cc01e48bf8dfcc9f1602a3a07f75aedb066b2f47 to 6c67860eb81580cd698b851a6141c4bb871b9906
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​95ebde1Merge branch 'develop' into t/22949/public/lie_algebras/as_fin_dim_algebra-22949
​6c67860Merge branch 'develop' into t/22949/public/lie_algebras/as_fin_dim_algebra-22949

comment:5 Changed 5 years ago by bsalisbury1

  • Status changed from needs_review to positive_review

I also merged with beta11.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from public/lie_algebras/as_fin_dim_algebra-22949 to 6c67860eb81580cd698b851a6141c4bb871b9906
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.