Opened 4 years ago

Closed 4 years ago

#22933 closed defect (fixed)

clean up deprecations in sandpile

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.0
Component: packages: standard Keywords:
Cc: jhpalmieri, dperkinson Merged in:
Authors: Dima Pasechnik Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 81e8959 (Commits, GitHub, GitLab) Commit: 81e89598c69e6f3affe099e2958e8f9c47c9a398
Dependencies: #22582 Stopgaps:

Status badges

Description (last modified by dimpase)

Some deprecation in sandpile are in fact already removed, but still present in lazy imports. This breaks ups vars() and locals().

Namely, these are grid_sandpile and complete_sandpile.

In fact, we should clean up everything that was deprecated in #18618.

However, we leave sandlib in the code, only remove it from the global namespace, as e.g. sandlib('gor') does not have an equivalent.

Also, it turns out that while calling vars() directly still fails, one now can at least do

v=vars()
for k in v.keys(): print v[k]

Change History (12)

comment:1 Changed 4 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/spfix
  • Description modified (diff)

comment:2 Changed 4 years ago by git

  • Commit set to d4b7838d5c80190468797faabea032eb93f5690d

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

dc46ea2trac 22582: fix merge conflicts
bc4c2f5trac 22582: rename build/bin/sage-python to sage-python23
0d30e20trac 22582: use sage-python23 to build the Sage library
7e7b5bctrac 22582: build and test packages using sage-python23 instead of python
b954864trac 22582: no need to make python2 a dependency for python3
2dad104trac 22582: a little documentation
5a645fdMerge branch 'public/22582' of trac.sagemath.org:sage into t/22582/public/22582
2179ac8Merge branch 8.0.beta3 into t/22582/public/22582
6d54e12Merge remote-tracking branch 'trac/public/22582' into spfix
d4b7838removed lazy_imports with deprecations

comment:3 Changed 4 years ago by dimpase

  • Cc jhpalmieri added
  • Status changed from new to needs_review

comment:4 Changed 4 years ago by jhpalmieri

Why is random_digraph no longer deprecated? (I know nothing about the sandpiles code, just wondering.)

comment:5 follow-up: Changed 4 years ago by jhpalmieri

There are several other places where you are removing deprecation warnings without removing the (previously) deprecated functions.

comment:6 in reply to: ↑ 5 Changed 4 years ago by dimpase

Replying to jhpalmieri:

There are several other places where you are removing deprecation warnings without removing the (previously) deprecated functions.

Deprecated was placing them into the global namespace. These functions are still used internally in the module.

comment:7 Changed 4 years ago by git

  • Commit changed from d4b7838d5c80190468797faabea032eb93f5690d to 81e89598c69e6f3affe099e2958e8f9c47c9a398

Branch pushed to git repo; I updated commit sha1. New commits:

f86a910removed previously deprecated firing_vector and random_digraph
81e8959fix a typo in a message

comment:8 Changed 4 years ago by dimpase

OK, I've removed two removable deprecated functions.

comment:9 Changed 4 years ago by dimpase

  • Cc dperkinson added

comment:10 Changed 4 years ago by jhpalmieri

This is not an issue that we should deal with on this ticket, but according to the deprecation notices, someone should move the functionality from sandlib to the catalog of examples accessible using sandpiles.

comment:11 Changed 4 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

I'm happy with the changes here.

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/dimpase/spfix to 81e89598c69e6f3affe099e2958e8f9c47c9a398
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.