Opened 2 years ago

Closed 2 years ago

#22930 closed defect (fixed)

Fixed broken install of Python 2 and 3 on Cygwin since #22764

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.0
Component: porting: Cygwin Keywords: python cygwin windows
Cc: tscrim Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 217a9da (Commits) Commit: 217a9da8903d88a79658ec8dd421744d72acf45b
Dependencies: Stopgaps:

Description

#22764 did not update the bits added by #20437 to reflect the removal of the "python" symlink.

In the process of investigating this I also realized I did not create the symlink for Python 3 correctly in the first place (but this was not noticed since we don't currently link anything against the Python 3 libpython during a normal Sage build).

Change History (4)

comment:1 Changed 2 years ago by embray

  • Authors set to Erik Bray
  • Branch set to u/embray/cygwin/python-install-2
  • Commit set to 217a9da8903d88a79658ec8dd421744d72acf45b
  • Status changed from new to needs_review

New commits:

217a9daFix linking to the import library for libpython on Python 2 and 3

comment:2 Changed 2 years ago by embray

  • Cc tscrim added
  • Keywords python cygwin windows added

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. Thanks.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/embray/cygwin/python-install-2 to 217a9da8903d88a79658ec8dd421744d72acf45b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.