Opened 3 years ago

Closed 3 years ago

#22929 closed defect (fixed)

Followup to #22666

Reported by: embray Owned by:
Priority: blocker Milestone: sage-8.0
Component: porting: Cygwin Keywords: windows cygwin python3
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9f553cd (Commits) Commit: 9f553cd56c65cd474e6d120990b187e68e279c32
Dependencies: #22666 Stopgaps:

Description

The Python 3 build is still broken in Cygwin since #22666. I mistakenly removed a patch that was still needed after all (or rather, I stripped away part of a patch that was still needed).

Change History (5)

comment:1 Changed 3 years ago by embray

  • Authors set to Erik Bray
  • Branch set to #22666
  • Dependencies set to u/embray/cygwin/python3-build-2
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by tscrim

  • Branch changed from #22666 to u/embray/cygwin/python3-build-2
  • Commit set to 9f553cd56c65cd474e6d120990b187e68e279c32
  • Dependencies changed from u/embray/cygwin/python3-build-2 to #22666
  • Reviewers set to Travis Scrimshaw

New commits:

9f553cdFix this patch, which was incorrectly changed in https://trac.sagemath.org/ticket/22666

comment:3 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

LGTM. Thanks.

comment:4 Changed 3 years ago by embray

  • Priority changed from major to blocker

This is actually a blocker.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/embray/cygwin/python3-build-2 to 9f553cd56c65cd474e6d120990b187e68e279c32
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.