Opened 2 years ago

Last modified 18 months ago

#22927 closed enhancement

Update gmpy2 package — at Version 27

Reported by: vklein Owned by: vklein
Priority: major Milestone: sage-8.2
Component: packages: optional Keywords: thursdaysbdx
Cc: vdelecroix Merged in:
Authors: Vincent Klein Reviewers:
Report Upstream: N/A Work issues:
Branch: u/vklein/add_gmpy2_as_an_optional_package (Commits) Commit: 596088c52896e3358a75f413ce040ac41ef192d9
Dependencies: Stopgaps:

Description (last modified by vklein)

Update gmpy2 package to have access to the gmpy2 C API.
Until the next release of gmpy2 we use a snapshot version gmpy2-snapshot-24.05.17.tar.gz
For now the check of the package fail, the issue has been reported to upstream (https://github.com/aleaxit/gmpy/issues/133)
Therefore don't use -c option to install the package

Change History (27)

comment:1 Changed 2 years ago by vklein

  • Owner changed from (none) to vklein

comment:2 Changed 2 years ago by vklein

  • Branch set to u/vklein/add_gmpy2_as_an_optional_package

comment:3 Changed 2 years ago by vdelecroix

  • Commit set to e4be88429637361c0c363f3a5d6a4cd59b24db98

Note that gmpy2 was already an optional package. The title and description of the ticket are not be appropriate.


New commits:

e4be884use a snapshot version of gmpy2

comment:4 Changed 2 years ago by vklein

  • Description modified (diff)

New commits:

e4be884use a snapshot version of gmpy2

comment:5 Changed 2 years ago by vklein

  • Description modified (diff)

comment:6 Changed 2 years ago by vklein

  • Description modified (diff)

comment:7 Changed 2 years ago by vklein

  • Description modified (diff)

comment:8 Changed 2 years ago by vklein

  • Description modified (diff)
  • Summary changed from Add gmpy2 as an optional package to Update gmpy2 package

comment:9 Changed 2 years ago by vdelecroix

  • Keywords jsb++ added

comment:10 Changed 2 years ago by vdelecroix

  • Keywords thursdaysbdx added; jsb++ removed

comment:11 Changed 2 years ago by git

  • Commit changed from e4be88429637361c0c363f3a5d6a4cd59b24db98 to 4f604c35a7bb7ba9aca106d9052f17e7b8f37e86

Branch pushed to git repo; I updated commit sha1. New commits:

4f604c3update checksum, snapshot version update in setup.py

comment:12 Changed 2 years ago by vklein

The version in the snapshot's setup.py was incorrect. ​https://www.labri.fr/perso/vklein/gmpy2-snapshot-02.05.17.tar.gz ans checksum.ini have been updated

Last edited 2 years ago by vklein (previous) (diff)

comment:13 Changed 2 years ago by vdelecroix

See gmpy pull request #134 for making mpz(a) and mpq(a) call the methods .__mpz__() and .__mpq__() respectively.

comment:14 Changed 2 years ago by git

  • Commit changed from 4f604c35a7bb7ba9aca106d9052f17e7b8f37e86 to 86560dfd220b1ce98481dbe77b052259c0052ba6

Branch pushed to git repo; I updated commit sha1. New commits:

ead4b30Merge branch ticket 22927 into 22928
d11c6afConversion between gmpy2 and sage integers
4a1c92eupdate checksum, snapshot version update in setup.py
87578d9Add path of gmpy2 in include_dirs
f1e9fe5Merge branch 'u/vklein/add_gmpy2_as_an_optional_package' of git://trac.sagemath.org/sage into t/22928/conversion_between_gmpy2_and_sage_integers
86560dfNew snapshot version, update checksum and package-version.txt

comment:15 Changed 2 years ago by git

  • Commit changed from 86560dfd220b1ce98481dbe77b052259c0052ba6 to 164e3981406dbd79bb326cde0c92f9e350e18f2e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

164e398New snapshot version, update checksum and package-version.txt

comment:16 Changed 2 years ago by vklein

New snapshot version gmpy2-snapshot-22.05.17.tar.gz, checksum has been updated.

comment:17 Changed 2 years ago by vklein

  • Description modified (diff)

comment:18 Changed 2 years ago by vklein

  • Component changed from packages: optional to packages: standard

comment:19 follow-up: Changed 2 years ago by jdemeyer

Why the change in component? If you want to make it standard, it should be discussed on sage-devel.

comment:20 in reply to: ↑ 19 ; follow-up: Changed 2 years ago by vdelecroix

Replying to jdemeyer:

Why the change in component? If you want to make it standard, it should be discussed on sage-devel.

Because of #23024. Of course it will be discussed on sage-devel. Note that the ticket status is new and there is no official release of gmpy2 yet.

comment:21 in reply to: ↑ 20 Changed 2 years ago by jdemeyer

Replying to vdelecroix:

Replying to jdemeyer:

Why the change in component? If you want to make it standard, it should be discussed on sage-devel.

Because of #23024. Of course it will be discussed on sage-devel. Note that the ticket status is new and there is no official release of gmpy2 yet.

Then why not keep it optional here and make it standard in #23024?

comment:22 follow-up: Changed 2 years ago by vklein

I don't see the point of keeping it optional here.

This ticket is a prerequisite of #22928 which is a prerequisite of #23024.

In my point of view, changes concerning gmpy2 package should be listed in this ticket, change concerning gmpy2 integration with sage in #22928 and change specifics to pplpy integration in #23024.

Last edited 2 years ago by vklein (previous) (diff)

comment:23 in reply to: ↑ 22 Changed 2 years ago by jdemeyer

Replying to vklein:

I don't see the point of keeping it optional here.

And I don't see any reason to make it standard here. It's not used by anything, so why should it be standard?

"Just having plans to use it in the future" is not sufficient reason IMHO to make a package standard.

comment:24 Changed 2 years ago by jdemeyer

Put in a different way: a Trac ticket should always be reviewed as a single unit. It's fine it the motivation for a Trac ticket comes from a different ticket, but the ticket should still make sense by itself.

comment:25 Changed 2 years ago by vklein

  • Component changed from packages: standard to packages: optional

And we can imagine an optional extension using gmpy2's C-API, ok i see your point.

comment:26 Changed 2 years ago by git

  • Commit changed from 164e3981406dbd79bb326cde0c92f9e350e18f2e to 596088c52896e3358a75f413ce040ac41ef192d9

Branch pushed to git repo; I updated commit sha1. New commits:

596088cUpdate checksum and snapshot version

comment:27 Changed 2 years ago by vklein

  • Description modified (diff)

Updating snapshot to version gmpy2-snapshot-24.05.17.tar.gz, the cython interface now include MPZ_Check and MPQ_Check function (Test if an object is of type gmpy2.mpz or gmpy2.mpq respectively)

Last edited 2 years ago by vklein (previous) (diff)
Note: See TracTickets for help on using tickets.