Opened 4 years ago
Closed 3 years ago
#22927 closed enhancement (fixed)
Update gmpy2 package
Reported by: | vklein | Owned by: | vklein |
---|---|---|---|
Priority: | major | Milestone: | sage-8.2 |
Component: | packages: optional | Keywords: | thursdaysbdx |
Cc: | vdelecroix | Merged in: | |
Authors: | Vincent Klein | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | e000563 (Commits, GitHub, GitLab) | Commit: | e0005636ed6db71bc8dca31418c9cb6519deb8f5 |
Dependencies: | Stopgaps: |
Description (last modified by )
Update gmpy2 package to have access to the gmpy2 C API.
Tarball : gmpy2-2.1.0a1.tar.gz
This gmpy2 version provides a Cython interface.
Change History (49)
comment:1 Changed 4 years ago by
- Owner changed from (none) to vklein
comment:2 Changed 4 years ago by
- Branch set to u/vklein/add_gmpy2_as_an_optional_package
comment:3 Changed 4 years ago by
- Commit set to e4be88429637361c0c363f3a5d6a4cd59b24db98
comment:4 Changed 4 years ago by
- Description modified (diff)
New commits:
e4be884 | use a snapshot version of gmpy2
|
comment:5 Changed 4 years ago by
- Description modified (diff)
comment:6 Changed 4 years ago by
- Description modified (diff)
comment:7 Changed 4 years ago by
- Description modified (diff)
comment:8 Changed 4 years ago by
- Description modified (diff)
- Summary changed from Add gmpy2 as an optional package to Update gmpy2 package
comment:9 Changed 4 years ago by
- Keywords jsb++ added
comment:10 Changed 4 years ago by
- Keywords thursdaysbdx added; jsb++ removed
comment:11 Changed 4 years ago by
- Commit changed from e4be88429637361c0c363f3a5d6a4cd59b24db98 to 4f604c35a7bb7ba9aca106d9052f17e7b8f37e86
Branch pushed to git repo; I updated commit sha1. New commits:
4f604c3 | update checksum, snapshot version update in setup.py
|
comment:12 Changed 4 years ago by
The version in the snapsht's setup.py was incorrect. https://www.labri.fr/perso/vklein/gmpy2-snapshot-02.05.17.tar.gz ans checksum.ini have been updated
comment:13 Changed 4 years ago by
See gmpy pull request #134 for making mpz(a)
and mpq(a)
call the methods .__mpz__()
and .__mpq__()
respectively.
comment:14 Changed 4 years ago by
- Commit changed from 4f604c35a7bb7ba9aca106d9052f17e7b8f37e86 to 86560dfd220b1ce98481dbe77b052259c0052ba6
Branch pushed to git repo; I updated commit sha1. New commits:
ead4b30 | Merge branch ticket 22927 into 22928
|
d11c6af | Conversion between gmpy2 and sage integers
|
4a1c92e | update checksum, snapshot version update in setup.py
|
87578d9 | Add path of gmpy2 in include_dirs
|
f1e9fe5 | Merge branch 'u/vklein/add_gmpy2_as_an_optional_package' of git://trac.sagemath.org/sage into t/22928/conversion_between_gmpy2_and_sage_integers
|
86560df | New snapshot version, update checksum and package-version.txt
|
comment:15 Changed 4 years ago by
- Commit changed from 86560dfd220b1ce98481dbe77b052259c0052ba6 to 164e3981406dbd79bb326cde0c92f9e350e18f2e
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
164e398 | New snapshot version, update checksum and package-version.txt
|
comment:16 Changed 4 years ago by
New snapshot version gmpy2-snapshot-22.05.17.tar.gz, checksum has been updated.
comment:17 Changed 4 years ago by
- Description modified (diff)
comment:18 Changed 4 years ago by
- Component changed from packages: optional to packages: standard
comment:19 follow-up: ↓ 20 Changed 4 years ago by
Why the change in component? If you want to make it standard, it should be discussed on sage-devel
.
comment:20 in reply to: ↑ 19 ; follow-up: ↓ 21 Changed 4 years ago by
comment:21 in reply to: ↑ 20 Changed 4 years ago by
Replying to vdelecroix:
Replying to jdemeyer:
Why the change in component? If you want to make it standard, it should be discussed on
sage-devel
.Because of #23024. Of course it will be discussed on
sage-devel
. Note that the ticket status isnew
and there is no official release of gmpy2 yet.
Then why not keep it optional here and make it standard in #23024?
comment:22 follow-up: ↓ 23 Changed 4 years ago by
I don't see the point of keeping it optional here.
This ticket is a prerequisite of #22928 which is a prerequisite of #23024.
In my point of view, changes concerning gmpy2 package should be listed in this ticket, change concerning gmpy2 integration with sage in #22928 and change specifics to pplpy integration in #23024.
comment:23 in reply to: ↑ 22 Changed 4 years ago by
Replying to vklein:
I don't see the point of keeping it optional here.
And I don't see any reason to make it standard here. It's not used by anything, so why should it be standard?
"Just having plans to use it in the future" is not sufficient reason IMHO to make a package standard.
comment:24 Changed 4 years ago by
Put in a different way: a Trac ticket should always be reviewed as a single unit. It's fine it the motivation for a Trac ticket comes from a different ticket, but the ticket should still make sense by itself.
comment:25 Changed 4 years ago by
- Component changed from packages: standard to packages: optional
And we can imagine an optional extension using gmpy2's C-API, ok i see your point.
comment:26 Changed 4 years ago by
- Commit changed from 164e3981406dbd79bb326cde0c92f9e350e18f2e to 596088c52896e3358a75f413ce040ac41ef192d9
Branch pushed to git repo; I updated commit sha1. New commits:
596088c | Update checksum and snapshot version
|
comment:27 Changed 4 years ago by
- Description modified (diff)
Updating snapshot to version gmpy2-snapshot-24.05.17.tar.gz, the cython interface now include MPZ_Check and MPQ_Check function (Test if an object is of type gmpy2.mpz or gmpy2.mpq respectively)
comment:28 Changed 4 years ago by
- Commit changed from 596088c52896e3358a75f413ce040ac41ef192d9 to c199ba816f61da30c51527f9254c11365e1d3723
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
613acaa | use a snapshot version of gmpy2
|
1baa88a | update checksum, snapshot version update in setup.py
|
d0fdf32 | New snapshot version, update checksum and package-version.txt
|
435a02e | Update checksum and snapshot version
|
c199ba8 | trac 22927 update gmpy2 snapshot version
|
comment:29 Changed 4 years ago by
Updating snapshot version to gmpy2-snapshot-22.06.17.tar.gz
comment:30 Changed 4 years ago by
- Description modified (diff)
comment:31 Changed 4 years ago by
- Commit changed from c199ba816f61da30c51527f9254c11365e1d3723 to 7e3505a83959a28502b0eb13d2e67f6f9882ef49
Branch pushed to git repo; I updated commit sha1. New commits:
7e3505a | trac 22927 update gmpy2 package version
|
comment:32 Changed 4 years ago by
Update snapshot version to gmpy2-snapshot-23.06.17.tar.gz
comment:33 Changed 3 years ago by
- Commit changed from 7e3505a83959a28502b0eb13d2e67f6f9882ef49 to aab4169b8b6d841cfa88709e99afd16e720c32cf
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d6072ca | use a snapshot version of gmpy2
|
ce7a082 | update checksum, snapshot version update in setup.py
|
2eca651 | New snapshot version, update checksum and package-version.txt
|
bd257c1 | Update checksum and snapshot version
|
32cc1ab | trac 22927 update gmpy2 snapshot version
|
aab4169 | trac 22927 update gmpy2 package version
|
comment:34 in reply to: ↑ description Changed 3 years ago by
Replying to vklein:
For now the check of the package fail
In that case, I'm not sure whether the package can be accepted. At a minimum, could you add a patch to disable the failing tests, such that gmpy2
at least formally passes its testsuite?
Second, you should better document how you obtained this tarball. Posting a tarball on your personal home page without further explanation is not sufficient. Is there any chance you could convince upstream to make a proper release? That would of course be much better.
Note that you have never set this ticket to needs_review. If you want this to be merged in Sage, you'll need to do that.
comment:35 Changed 3 years ago by
- Description modified (diff)
Is there any chance you could convince upstream to make a proper release?
Our goal has always be to have a proper release of gmpy2. It look like things are progressing well these last weeks. You can look at issue #146 if you want more specifics.
comment:36 Changed 3 years ago by
- Commit changed from aab4169b8b6d841cfa88709e99afd16e720c32cf to 0ba3ffb09762bbf7c08196702224bdd36fce2fdc
Branch pushed to git repo; I updated commit sha1. New commits:
0ba3ffb | trac 22927: update package version to snapshot-14.11.17
|
comment:37 Changed 3 years ago by
- Description modified (diff)
update package version to gmpy2-snapshot-14.11.17.tar.gz
comment:38 Changed 3 years ago by
- Commit changed from 0ba3ffb09762bbf7c08196702224bdd36fce2fdc to a7bdad60ea81f438bba979d01f0c9e0e0b5d4b4c
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
a7bdad6 | Trac #22927: update package version to snapshot-14.11.17
|
comment:39 Changed 3 years ago by
rebase on 8.1.rc0 and squash commit
comment:40 Changed 3 years ago by
- Commit changed from a7bdad60ea81f438bba979d01f0c9e0e0b5d4b4c to e0005636ed6db71bc8dca31418c9cb6519deb8f5
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
e000563 | Trac #22927 gmpy2 update package version to 2.1.0a1
|
comment:41 Changed 3 years ago by
- Description modified (diff)
comment:42 Changed 3 years ago by
- Status changed from new to needs_review
comment:43 Changed 3 years ago by
- Description modified (diff)
- Reviewers set to Jeroen Demeyer
comment:44 Changed 3 years ago by
Running make ptestlong
now, but I don't expect any problems.
comment:45 follow-up: ↓ 47 Changed 3 years ago by
(me too (running ptestlong))
comment:46 Changed 3 years ago by
- Milestone changed from sage-8.0 to sage-8.2
comment:47 in reply to: ↑ 45 Changed 3 years ago by
comment:48 Changed 3 years ago by
- Status changed from needs_review to positive_review
comment:49 Changed 3 years ago by
- Branch changed from u/vklein/add_gmpy2_as_an_optional_package to e0005636ed6db71bc8dca31418c9cb6519deb8f5
- Resolution set to fixed
- Status changed from positive_review to closed
Note that gmpy2 was already an optional package. The title and description of the ticket are not be appropriate.
New commits:
use a snapshot version of gmpy2