Opened 2 years ago

Closed 2 years ago

#22925 closed defect (fixed)

Fix Cython interface to Pynac's find_function

Reported by: rws Owned by:
Priority: minor Milestone: sage-8.0
Component: interfaces Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 143f133 (Commits) Commit: 143f133690a95a8ac514b7c9226b94e8a953550b
Dependencies: Stopgaps:

Description

There is ancient code in pynac.pxd that causes failures with Pynac dev versions. Especially the construct except +ValueError doesn't work as apparently assumed.

Change History (4)

comment:1 Changed 2 years ago by rws

  • Branch set to u/rws/fix_cython_interface_to_pynac_s_find_function

comment:2 Changed 2 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 143f133690a95a8ac514b7c9226b94e8a953550b
  • Status changed from new to needs_review

New commits:

143f13322925: Fix Cython interface to Pynac's find_function

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from u/rws/fix_cython_interface_to_pynac_s_find_function to 143f133690a95a8ac514b7c9226b94e8a953550b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.